feat(Menu): Prototype#14822
Merged
msft-github-bot merged 12 commits intomicrosoft:masterfrom Sep 7, 2020
Merged
Conversation
assuncaocharles
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Contributor
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b24308f:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a6337607bf1742ce64f73eb6ddb420960919bdb9 (build) |
layershifter
reviewed
Sep 1, 2020
layershifter
reviewed
Sep 1, 2020
Contributor
Author
|
Anything else @layershifter ? |
Contributor
Author
|
@miroslavstastny , @mnajdova , @pompomon Maybe you can also check if you have any thoughts on this? |
layershifter
approved these changes
Sep 7, 2020
Contributor
|
Hello @assuncaocharles! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
hutchcodes
pushed a commit
to hutchcodes/fluentui
that referenced
this pull request
Sep 10, 2020
#### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes As agreed this PR adds a **private** prototype for `Menu` with submenus  #### Focus areas to test (optional)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
As agreed this PR adds a private prototype for
Menuwith submenusFocus areas to test
(optional)