Update section header type #15123
Merged
Update section header type #15123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…menu item in the props seperately
…ContextualMenu.base.tsx Co-Authored-By: Xu Gao <xugao0131@hotmail.com>
…flow at 99 to prevent large numbers from overflowing outside of the buttons bounds
Contributor
Author
|
@joschect I had to resubmit the PR as I don't have access to Matt branch to resolve the merge conflicts |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 49b121f:
|
Contributor
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
# Conflicts: # packages/office-ui-fabric-react/etc/office-ui-fabric-react.api.md
Asset size changesUnable to find bundle size details for Baseline commit: d727c1a Possible causes
Recommendations
|
Contributor
|
As part of our version 8 release we need folks to port changes to this component to the react-next package as well. Could you make this change in react-next as well? |
…pdateSectionHeaderType # Conflicts: # packages/office-ui-fabric-react/etc/office-ui-fabric-react.api.md
Contributor
Author
Made the relevant changes and pushed |
khmakoto
requested changes
Sep 28, 2020
Member
khmakoto
left a comment
khmakoto
left a comment
There was a problem hiding this comment.
Thanks for submitting this fix, but due to work we're currently doing to prepare master for our version 8 beta release, we're asking contributors to either wait a couple weeks to submit fixes (if it's not urgent) or submit to the new 7.0 branch (if it's urgent). See #15222 for more details.
joschect
approved these changes
Sep 29, 2020
khmakoto
approved these changes
Sep 29, 2020
Contributor
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Contributor
|
🎉 Handy links: |
Contributor
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sectionProps limits the title prop to a string. This prevents sending any additional properties to the title.
A while ago, there was a PR to apply html div properties specified on itemProps of a an IContextualMenuItem element to the surrounding div of the section header.
This PR makes parity with that.
Focus areas to test
Titles still render on contextual menus
This is a resubmit of #14069