feat: add Text component to react-text
#15304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dzearing,
ecraig12345 and
xugao
as code owners
Contributor
|
Thanks for submitting this change, but due to work currently in progress to prepare |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1ceebec:
|
Contributor
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesUnable to find bundle size details for Baseline commit: 8827b37 Possible causes
Recommendations
|
layershifter
force-pushed
the
feat/react-text
branch
from
31719af to
967864a
Compare
layershifter
commented
Oct 1, 2020
layershifter
force-pushed
the
feat/react-text
branch
3 times, most recently
from
1d6f58f to
867fa1d
Compare
layershifter
force-pushed
the
feat/react-text
branch
from
867fa1d to
3d156a8
Compare
khmakoto
reviewed
Oct 3, 2020
Co-authored-by: Makoto Morimoto <humbertomakotomorimoto@gmail.com>
…eat/react-text
khmakoto
approved these changes
Oct 5, 2020
Member
|
Seems like you need to run |
…eat/react-text � Conflicts: � packages/react-theme-provider/src/__snapshots__/ThemeProvider.test.tsx.snap � packages/react-theme-provider/src/getTokens.ts
…eat/react-text
dzearing
reviewed
Oct 7, 2020
| root: 'ms-Text', | ||
| }; | ||
|
|
||
| export const useTextClasses = makeClasses({ |
Member
There was a problem hiding this comment.
this looks great, and also, I just merged makeVariantClasses should we want these to be easily definable and extendable in the theme. Can sync later on this.
Contributor
|
🎉 Handy links: |
Contributor
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an initial version of
Textin@fluentui/react-text.