Skip to content

Use type from state iff canRevealPassword is true #15673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecraig12345 merged 4 commits into from
Oct 27, 2020
Merged

Use type from state iff canRevealPassword is true #15673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29a920f
Use type from state iff canRevealPassword is true
faizal3199 Oct 23, 2020
5f5373c
Use this.props instead of native props
faizal3199 Oct 23, 2020
bc9953f
Forced changes to trigger yarn change
faizal3199 Oct 24, 2020
f554d88
Change files
faizal3199 Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/office-ui-fabric-react-2020-10-24-10-42-39-7.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "TextField: Use type from state iff canRevealPassword is true",
"packageName": "office-ui-fabric-react",
"email": "fahasanw@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-10-24T05:12:39.137Z"
}
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/TextField/TextField.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,12 +484,13 @@ export class TextFieldBase extends React.Component<ITextFieldProps, ITextFieldSt
'defaultValue',
]);
const ariaLabelledBy = this.props['aria-labelledby'] || (this.props.label ? this._labelId : undefined);
const type = this.props.canRevealPassword ? this.state.type : this.props.type ?? 'text';
return (
<input
id={this._id}
aria-labelledby={ariaLabelledBy}
{...inputProps}
type={this.state.type}
type={type}
ref={this._textElement as React.RefObject<HTMLInputElement>}
value={this.value || ''}
onInput={this._onInputChange}
Expand Down