Skip to content

Conversation

@xugao
Copy link
Contributor

@xugao xugao commented Oct 30, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Add react-theme-provider and react-stylesheet packages in 7.0 branch, because:

  1. version for dependency react-window-provider package has fall behind. (it was previously bumped to major version 1). Therefore we should publish new version of react-theme-provider in order to avoid package duplications for users.
  2. We will be exporting react-theme-provider from v7 OUFR later.

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 30, 2020
@xugao xugao removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 30, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 69cad72:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 931 911 5000
Breadcrumb mount 39498 39330 5000
Checkbox mount 1592 1623 5000
CheckboxBase mount 1329 1344 5000
ChoiceGroup mount 5043 5023 5000
ComboBox mount 916 903 1000
CommandBar mount 7414 7379 1000
ContextualMenu mount 12504 12349 1000
DefaultButton mount 1130 1145 5000
DetailsRow mount 3549 3609 5000
DetailsRowFast mount 3634 3602 5000
DetailsRowNoStyles mount 3487 3552 5000
Dialog mount 1570 1505 1000
DocumentCardTitle mount 1794 1841 1000
Dropdown mount 2584 2637 5000
FocusTrapZone mount 1780 1719 5000
FocusZone mount 1891 1849 5000
IconButton mount 1846 1869 5000
Label mount 329 333 5000
Layer mount 2022 1967 5000
Link mount 442 454 5000
MenuButton mount 1571 1528 5000
MessageBar mount 2083 2075 5000
Nav mount 3366 3391 1000
OverflowSet mount 1465 1499 5000
Panel mount 1468 1455 1000
Persona mount 823 829 1000
Pivot mount 1415 1428 1000
PrimaryButton mount 1325 1287 5000
Rating mount 7824 7719 5000
SearchBox mount 1307 1307 5000
Shimmer mount 2583 2580 5000
Slider mount 1479 1475 5000
SpinButton mount 5039 5080 5000
Spinner mount 402 393 5000
SplitButton mount 3169 3218 5000
Stack mount 507 486 5000
StackWithIntrinsicChildren mount 1545 1577 5000
StackWithTextChildren mount 4739 4849 5000
SwatchColorPicker mount 10168 10321 5000
TagPicker mount 2805 2773 5000
TeachingBubble mount 47569 47901 5000
Text mount 429 429 5000
TextField mount 1398 1388 5000
Toggle mount 805 834 5000
button mount 98 98 5000

@size-auditor
Copy link

size-auditor bot commented Oct 30, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3facc40caa530b05a4fa970d34a3b579f5f46f6c (build)

@xugao xugao merged commit 958dd32 into microsoft:7.0 Oct 30, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-theme-provider@v0.16.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-examples@v0.8.6 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-stylesheets@v0.2.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants