Skip to content

Conversation

@Dalimil
Copy link
Contributor

@Dalimil Dalimil commented Nov 6, 2020

Pull request checklist

Description of changes

These files need to be exported to avoid deep imports (incompatible in fluentui/react)

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Nov 6, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 08819ed:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@ecraig12345
Copy link
Member

Just curious, what's the scenario where you're using these directly? Feel free to message me on teams if that's easier.

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Nov 9, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 1027 1006 5000
Breadcrumb mount 45067 44628 5000
Checkbox mount 1698 1736 5000
CheckboxBase mount 1443 1435 5000
ChoiceGroup mount 5473 5502 5000
ComboBox mount 950 948 1000
CommandBar mount 8437 8469 1000
ContextualMenu mount 17330 17041 1000
DefaultButton mount 1269 1296 5000
DetailsRow mount 3885 3931 5000
DetailsRowFast mount 4132 3934 5000
DetailsRowNoStyles mount 3766 3744 5000
Dialog mount 1641 1618 1000
DocumentCardTitle mount 1925 1864 1000
Dropdown mount 2846 2837 5000
FocusTrapZone mount 1816 1788 5000
FocusZone mount 1835 1919 5000
IconButton mount 1929 1955 5000
Label mount 361 351 5000
Layer mount 2121 2090 5000
Link mount 490 489 5000
MenuButton mount 1644 1624 5000
MessageBar mount 2185 2184 5000
Nav mount 3523 3597 1000
OverflowSet mount 1553 1520 5000
Panel mount 1587 1610 1000
Persona mount 873 902 1000
Pivot mount 1571 1525 1000
PrimaryButton mount 1382 1430 5000
Rating mount 8424 8358 5000
SearchBox mount 1429 1375 5000
Shimmer mount 2804 2805 5000
Slider mount 1610 1590 5000
SpinButton mount 5508 5343 5000
Spinner mount 430 448 5000
SplitButton mount 3462 3494 5000
Stack mount 539 536 5000
StackWithIntrinsicChildren mount 1667 1676 5000
StackWithTextChildren mount 5144 5079 5000
SwatchColorPicker mount 11278 11133 5000
TagPicker mount 2941 2968 5000
TeachingBubble mount 53596 53685 5000
Text mount 461 459 5000
TextField mount 1502 1528 5000
Toggle mount 933 911 5000
button mount 110 111 5000

@size-auditor
Copy link

size-auditor bot commented Nov 9, 2020

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-Callout 84.109 kB 84.209 kB ExceedsBaseline     100 bytes
office-ui-fabric-react office-ui-fabric-react-Panel 193.81 kB 193.853 kB ExceedsBaseline     43 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 1ecf8f1b3c84b6ea95e5cfcff2a93cddfb2164da (build)

@joschect joschect merged commit 3c38bf5 into microsoft:7.0 Nov 10, 2020
@Dalimil Dalimil mentioned this pull request Nov 10, 2020
1 task
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.150.0 has been released which incorporates this pull request.:tada:

Handy links:

@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants