Skip to content

Conversation

@xugao
Copy link
Contributor

@xugao xugao commented Nov 17, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Add react-button related back to 7.0 branch so v0 related fixes get published. Changes include:

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Nov 17, 2020
@xugao xugao requested a review from khmakoto November 17, 2020 01:28
@xugao xugao removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Nov 17, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 631a4cb:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Nov 17, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 996 978 5000
Breadcrumb mount 43574 43003 5000
Checkbox mount 1711 1707 5000
CheckboxBase mount 1404 1408 5000
ChoiceGroup mount 5515 5301 5000
ComboBox mount 990 994 1000
CommandBar mount 7963 8037 1000
ContextualMenu mount 13684 13669 1000
DefaultButton mount 1191 1194 5000
DetailsRow mount 3882 3847 5000
DetailsRowFast mount 3824 3803 5000
DetailsRowNoStyles mount 3634 3681 5000
Dialog mount 1605 1554 1000
DocumentCardTitle mount 1869 1866 1000
Dropdown mount 2710 2747 5000
FocusTrapZone mount 1805 1771 5000
FocusZone mount 1875 1883 5000
IconButton mount 1918 1927 5000
Label mount 344 354 5000
Layer mount 2085 2108 5000
Link mount 491 481 5000
MenuButton mount 1587 1613 5000
MessageBar mount 2132 2152 5000
Nav mount 3424 3485 1000
OverflowSet mount 1455 1485 5000
Panel mount 1514 1517 1000
Persona mount 880 885 1000
Pivot mount 1496 1537 1000
PrimaryButton mount 1410 1335 5000
Rating mount 8395 8248 5000
SearchBox mount 1396 1414 5000
Shimmer mount 2739 2757 5000
Slider mount 1577 1570 5000
SpinButton mount 5334 5303 5000
Spinner mount 447 432 5000
SplitButton mount 3367 3360 5000
Stack mount 520 560 5000
StackWithIntrinsicChildren mount 1667 1650 5000
StackWithTextChildren mount 5061 5045 5000
SwatchColorPicker mount 10963 10755 5000
TagPicker mount 2955 2903 5000
TeachingBubble mount 52965 52245 5000
Text mount 449 449 5000
TextField mount 1487 1495 5000
Toggle mount 895 891 5000
button mount 102 106 5000

@size-auditor
Copy link

size-auditor bot commented Nov 17, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 86697453db862090793b439d55ffe65b6d2bbaa9 (build)

@dzearing dzearing merged commit 17abde4 into microsoft:7.0 Nov 17, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/theme@v1.7.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/storybook@v0.5.26 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-theme-provider@v0.17.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-shared-contexts@v0.1.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-examples@v0.9.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-button@v0.18.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants