Fully respect skipViewportMeasures in the withViewport decorator
#15963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs cherry-pick
ThomasMichon
commented
Nov 17, 2020
| } | ||
| } | ||
|
|
||
| public componentDidUpdate(newProps: TProps) { |
Member
Author
There was a problem hiding this comment.
I have no idea why people didn't notice that the contract was wrong here for so long.
ThomasMichon
commented
Nov 17, 2020
packages/office-ui-fabric-react/src/utilities/decorators/withViewport.tsx
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6aec401:
|
ThomasMichon
force-pushed
the
viewport-measure
branch
from
6aac50a to
a60e0c7
Compare
Contributor
Perf AnalysisNo significant results to display. All results
|
Asset size changes
Baseline commit: 922a86f8f337a2fb1d6bf480736aac8118dfffb8 (build) |
packages/office-ui-fabric-react/src/utilities/decorators/withViewport.tsx
Outdated
Show resolved
Hide resolved
ThomasMichon
force-pushed
the
viewport-measure
branch
from
a60e0c7 to
38c2f65
Compare
KevinTCoughlin
approved these changes
Nov 18, 2020
Contributor
|
Hello @KevinTCoughlin! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Contributor
|
🎉 Handy links: |
ecraig12345
removed
the
needs cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The expectation of
skipViewportMeasuresonwithViewport(and thus onDetailsList) is that when set, no measurement of the viewport size occurs and thusviewportwill never be set to a non-empty size in thepropsof the wrapped component.However, somewhere along the way,
skipViewportMeasuresgot partially repurposed so that it only disables usage ofResizeObserverand does not fully prevent the wrapped component from re-rendering in response to viewport size changes.This change restores
skipViewportMeasuresto its original intent and how existing apps already expect it to work.This change also fixes the comment in order to explain why to use it.
Focus areas to test
The justified layout behavior of
DetailsListrelies on viewport measurement continuing to work correctly. Test code and 'fixed layout' behaviors rely onskipViewportMeasurescompletely disabling measurment.