Skip to content

applyClasses cherrypick to 7.0 branch #15968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dzearing merged 4 commits into from
Nov 18, 2020
Merged

applyClasses cherrypick to 7.0 branch #15968

dzearing merged 4 commits into from
Nov 18, 2020

Conversation

@dzearing
Copy link
Member

@dzearing dzearing commented Nov 18, 2020 •
edited by xugao
Loading

cherrypick #15959

@dzearing dzearing requested a review from xugao as a code owner November 18, 2020 03:35
@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Nov 18, 2020
@dzearing dzearing changed the title Fix/apply classes cherrypick applyClasses cherrypick to 7.0 branch Nov 18, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 18, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c8596d:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@dzearing
Merge branch '7.0' of https://github.com/microsoft/fluentui into 7.0
dc999bb 
# Conflicts:
#	packages/office-ui-fabric-react/src/components/GroupedList/GroupedList.base.tsx
@msft-github-bot
Copy link
Contributor

msft-github-bot commented Nov 18, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 978 1013 5000
Breadcrumb mount 43148 43249 5000
Checkbox mount 1683 1674 5000
CheckboxBase mount 1374 1450 5000
ChoiceGroup mount 5283 5369 5000
ComboBox mount 943 955 1000
CommandBar mount 7886 7961 1000
ContextualMenu mount 13816 13770 1000
DefaultButton mount 1218 1189 5000
DetailsRow mount 3841 3847 5000
DetailsRowFast mount 3829 3808 5000
DetailsRowNoStyles mount 3553 3619 5000
Dialog mount 1577 1584 1000
DocumentCardTitle mount 1871 1956 1000
Dropdown mount 2702 2784 5000
FocusTrapZone mount 1824 1813 5000
FocusZone mount 1863 1838 5000
IconButton mount 1925 1900 5000
Label mount 365 343 5000
Layer mount 2080 2063 5000
Link mount 462 490 5000
MenuButton mount 1624 1612 5000
MessageBar mount 2170 2199 5000
Nav mount 3517 3467 1000
OverflowSet mount 1468 1469 5000
Panel mount 1530 1501 1000
Persona mount 915 878 1000
Pivot mount 1540 1493 1000
PrimaryButton mount 1366 1410 5000
Rating mount 8277 8243 5000
SearchBox mount 1387 1408 5000
Shimmer mount 2731 2791 5000
Slider mount 1632 1598 5000
SpinButton mount 5209 5251 5000
Spinner mount 407 420 5000
SplitButton mount 3369 3354 5000
Stack mount 532 542 5000
StackWithIntrinsicChildren mount 1643 1630 5000
StackWithTextChildren mount 5075 5030 5000
SwatchColorPicker mount 11056 10857 5000
TagPicker mount 2942 2925 5000
TeachingBubble mount 51893 52741 5000
Text mount 455 451 5000
TextField mount 1493 1458 5000
Toggle mount 862 889 5000
button mount 105 110 5000

@size-auditor
Copy link

size-auditor bot commented Nov 18, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 922a86f8f337a2fb1d6bf480736aac8118dfffb8 (build)

xugao
xugao reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@xugao xugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some unexpected test failures

@xugao xugao removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Nov 18, 2020
@dzearing dzearing merged commit 002bb12 into microsoft:7.0 Nov 18, 2020
@dzearing dzearing deleted the fix/applyClasses-cherrypick branch November 18, 2020 05:56
@msft-github-bot
Copy link
Contributor

msft-github-bot commented Nov 18, 2020

🎉@fluentui/react-theme-provider@v0.18.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xugao xugao xugao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@behowell behowell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dzearing @msft-github-bot @xugao @behowell