Fix tooltip swallowing keydown events for close in the event that the tooltip is already closed. #15990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
Component: Dialog
needs cherry-pick
stefaniehansen
changed the title
stefaniehansen
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4cdc3b8:
|
Contributor
Perf AnalysisNo significant results to display. All results
|
Asset size changes
Baseline commit: 9812fcdcad2bc081ec41c4bee23a5e935533b3ea (build) |
micahgodbolt
approved these changes
Nov 19, 2020
2 tasks
behowell
removed
the
needs cherry-pick
Contributor
|
🎉 Handy links: |
msft-github-bot
pushed a commit
that referenced
this pull request
Nov 25, 2020
#### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [X] Include a change request file using `$ yarn change` #### Description of changes Currently, we are attempting to capture keydown events on the tooltip (particularly the Escape and Ctrl key) even when the tooltip is closed. This means that in the event that the tooltip belongs to an element in a dialog or another component that listens to the same keydown event, the event is swallowed. We should check to see that the tooltip is open before attempting to handle this event (so that we don't stop event propagation). This is a cherry-pick from a change that was recently merged into v7.0 in this pull request. #15990 #### Focus areas to test (optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Currently, we are attempting to capture keydown events on the tooltip (particularly the Escape and Ctrl key) even when the tooltip is closed. This means that in the event that the tooltip belongs to an element in a dialog or another component that listens to the same keydown event, the event is swallowed. We should check to see that the tooltip is open before attempting to handle this event (so that we don't stop event propagation).
Focus areas to test
(optional)