Prevent '.ms-Icon' style overrides from conflicting with the "Move column" target #16014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs cherry-pick
KevinTCoughlin
approved these changes
Nov 20, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d2200f9:
|
Contributor
Perf AnalysisNo significant results to display. All results
|
Asset size changes
Baseline commit: a01b37729af7f9c168547049355dc59fadc942ba (build) |
Member
|
CI reports snapshots need to be updated. However, info @fluentui/react-shared-contexts update-snapshots ❌ fail
info 🏗 Summary
info
verb @fluentui/react-stylesheets update-snapshots started - incomplete, took 0.00s
verb @fluentui/react-shared-contexts update-snapshots failed, took 18.64s
verb @fluentui/react-window-provider update-snapshots started - incomplete, took 0.00s
verb @uifabric/utilities update-snapshots started - incomplete, took 0.00s
info [Tasks Count] success: 0, skipped: 0, incomplete: 4
info ----------------------------------------------
ERR! [@fluentui/react-shared-contexts update-snapshots] ERROR DETECTED
ERR! started
ERR! hash: ba57f61859a387ac4f0ede0e9e1befcfb6064772, cache hit? false
ERR! Running C:\Users\kevin\AppData\Local\nvs\default\npm.CMD run update-snapshots
ERR! > @fluentui/react-shared-contexts@0.1.1 update-snapshots C:\Users\kevin\Work\office-ui-fabric-react\packages\react-shared-contexts
ERR! > just-scripts jest -u
ERR! [3:06:42 PM] ■ started 'jest'
ERR! [3:06:42 PM] ■ Running Jest
ERR! [3:06:42 PM] ■ C:\Users\kevin\AppData\Local\nvs\default\node.exe "C:\Users\kevin\Work\office-ui-fabric-react\node_modules\jest\bin\jest.js" --config "C:\Users\kevin\Work\office-ui-fabric-react\packages\react-shared-contexts\jest.config.js" --colors --updateSnapshot
ERR! No tests found, exiting with code 1
ERR! Run with `--passWithNoTests` to exit with code 0
ERR! In C:\Users\kevin\Work\office-ui-fabric-react\packages\react-shared-contexts
ERR! 14 files checked.
ERR! testMatch: - 0 matches
ERR! testPathIgnorePatterns: \\node_modules\\ - 14 matches
ERR! testRegex: (\\__tests__\\.*|\.(test|spec))\.(ts|tsx)$ - 0 matches
ERR! Pattern: - 0 matches
ERR! [3:06:46 PM] x Error detected while running 'jest'
ERR! [3:06:46 PM] x ------------------------------------
ERR! [3:06:46 PM] x Error: Command failed: C:\Users\kevin\AppData\Local\nvs\default\node.exe C:\Users\kevin\Work\office-ui-fabric-react\node_modules\jest\bin\jest.js --config C:\Users\kevin\Work\office-ui-fabric-react\packages\react-shared-contexts\jest.config.js --colors --updateSnapshot |
ThomasMichon
force-pushed
the
details-column-marker
branch
from
d3c1f6b to
5a57037
Compare
dzearing
approved these changes
Nov 21, 2020
ThomasMichon
force-pushed
the
details-column-marker
branch
from
5a57037 to
2726719
Compare
Member
|
CI is complaining about a missing change file: |
Contributor
|
Hello @KevinTCoughlin! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Contributor
|
🎉 Handy links: |
Contributor
|
🎉 Handy links: |
ecraig12345
removed
the
needs cherry-pick
ecraig12345
added
the
needs cherry-pick
jdhuntington
pushed a commit
that referenced
this pull request
Feb 23, 2021
…lumn" target (#16014) Added a wrapper element around the drop target icons for column headers so that styles which mess with the display style for `ms-Icon` do not cause the target hints to all render at once. This way, the visibility of the icon is controlled independently from its style, and should now only appear when the target is active. Dragging and dropping column headers in `DetailsList`.
2 tasks
ecraig12345
removed
the
needs cherry-pick
jdhuntington
pushed a commit
that referenced
this pull request
Feb 23, 2021
…lumn" target (#16014) Added a wrapper element around the drop target icons for column headers so that styles which mess with the display style for `ms-Icon` do not cause the target hints to all render at once. This way, the visibility of the icon is controlled independently from its style, and should now only appear when the target is active. Dragging and dropping column headers in `DetailsList`.
joschect
pushed a commit
that referenced
this pull request
Feb 23, 2021
…lumn" target (#16014) (#17124) Added a wrapper element around the drop target icons for column headers so that styles which mess with the display style for `ms-Icon` do not cause the target hints to all render at once. This way, the visibility of the icon is controlled independently from its style, and should now only appear when the target is active. Dragging and dropping column headers in `DetailsList`. Co-authored-by: Thomas Michon <tmichon@microsoft.com>
Collaborator
|
🎉This issue was addressed in #17124, which has now been successfully released as Handy links: |
Collaborator
|
🎉This issue was addressed in #17124, which has now been successfully released as Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
…lumn" target (microsoft#16014) (microsoft#17124) Added a wrapper element around the drop target icons for column headers so that styles which mess with the display style for `ms-Icon` do not cause the target hints to all render at once. This way, the visibility of the icon is controlled independently from its style, and should now only appear when the target is active. Dragging and dropping column headers in `DetailsList`. Co-authored-by: Thomas Michon <tmichon@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added a wrapper element around the drop target icons for column headers so that styles which mess with the display style for
ms-Icondo not cause the target hints to all render at once. This way, the visibility of the icon is controlled independently from its style, and should now only appear when the target is active.Focus areas to test
Dragging and dropping column headers in
DetailsList.