Skip to content

Conversation

@nloyolag
Copy link

Pull request checklist

Description of changes

As discussed in issue #15772, GroupedList doesn't receive HTML attributes and other properties (e.g. aria-labelledby). The agreed solution was to pass rootListProps following the pattern of focusZoneProps.

Focus areas to test

  • Making sure props are passed to parent list

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Nov 23, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 408c3c6:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
FocusZone mount 1849 1932 5000 Possible regression
All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 979 984 5000
Breadcrumb mount 42293 42276 5000
Checkbox mount 1664 1670 5000
CheckboxBase mount 1359 1421 5000
ChoiceGroup mount 5280 5278 5000
ComboBox mount 954 928 1000
CommandBar mount 7878 7945 1000
ContextualMenu mount 14151 13807 1000
DefaultButton mount 1214 1232 5000
DetailsRow mount 3977 3780 5000
DetailsRowFast mount 3903 3874 5000
DetailsRowNoStyles mount 3620 3697 5000
Dialog mount 1602 1570 1000
DocumentCardTitle mount 1816 1837 1000
Dropdown mount 2763 2697 5000
FocusTrapZone mount 1824 1792 5000
FocusZone mount 1849 1932 5000 Possible regression
IconButton mount 1921 1939 5000
Label mount 363 337 5000
Layer mount 2103 2102 5000
Link mount 466 455 5000
MenuButton mount 1570 1595 5000
MessageBar mount 2157 2154 5000
Nav mount 3432 3424 1000
OverflowSet mount 1510 1497 5000
Panel mount 1499 1544 1000
Persona mount 867 903 1000
Pivot mount 1492 1484 1000
PrimaryButton mount 1361 1353 5000
Rating mount 8239 8295 5000
SearchBox mount 1389 1354 5000
Shimmer mount 2759 2762 5000
Slider mount 1544 1581 5000
SpinButton mount 5305 5238 5000
Spinner mount 427 410 5000
SplitButton mount 3371 3337 5000
Stack mount 526 543 5000
StackWithIntrinsicChildren mount 1603 1625 5000
StackWithTextChildren mount 5004 5022 5000
SwatchColorPicker mount 11003 10955 5000
TagPicker mount 3024 2946 5000
TeachingBubble mount 51163 50822 5000
Text mount 445 460 5000
TextField mount 1456 1453 5000
Toggle mount 872 871 5000
button mount 101 116 5000

@size-auditor
Copy link

size-auditor bot commented Nov 23, 2020

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-DetailsList 215.631 kB 215.672 kB ExceedsBaseline     41 bytes
office-ui-fabric-react office-ui-fabric-react-ShimmeredDetailsList 226.039 kB 226.08 kB ExceedsBaseline     41 bytes
office-ui-fabric-react office-ui-fabric-react-GroupedList 121.97 kB 122.011 kB ExceedsBaseline     41 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: ce5fa0ab118812d2b188a990de503a37b6b77e1d (build)

@dzearing dzearing merged commit 9999a34 into microsoft:7.0 Nov 23, 2020
@nloyolag nloyolag deleted the noloyola/rootListProps branch November 23, 2020 22:47
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.153.0 has been released which incorporates this pull request.:tada:

Handy links:

@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants