Tooltip: Fix positioning issues that can cause tooltip to flash/not render #16454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-fluent-ui-bot
added
the
needs cherry-pick
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 353b25e:
|
Collaborator
Perf AnalysisNo significant results to display. All results
|
Asset size changes
Baseline commit: ae56e24c4fcb61d9d9def1a39d264dfa538b6c12 (build) |
Contributor
Author
dzearing
approved these changes
Jan 19, 2021
Collaborator
|
🎉 Handy links: |
ecraig12345
added
Component: Tooltip
Component: Callout
and removed
needs cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Prior to this change there were cases where the tooltip may occlude its targetElement which could cause the tooltip to flash or potentially not appear at all. The issue becomes more prominent if one of more of the follow ins is present:
tooltipGapSpaceis not a whole number of pixels, this is exacerbated the larger the user's devicePixelRatio which can lead to an overlap at the bottom of the targetElement (because the::afterelement is slightly occluding the bottom of the targetElement)To fix these issues I've made two fixes:
OFF_SCREEN_STYLEwhich sets the opacity, but the callout can still occlude the targetElement. I'm adding pointerEvents: none to the styling that is applied in this case so that it will not fire mouse eventstooltipGapSpacecalculation to take into account the user'sdevicePixelRatioand compensate for the sub-pixel roundingFocus areas to test
Verified that there is no functional behavior change outside of the fact that the targetElement is no longer occluded all the way up to 500% browser zoom across IE11, Edge, Chrome, FF, and Safari on Mac