fix(react v7): Add missing HighContrast override to SplitButton #16635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-fluent-ui-bot
added
Area: Theming
needs cherry-pick
theerebuss
commented
Jan 26, 2021
| marginTop: 0, | ||
| marginRight: 0, | ||
| marginBottom: 0, | ||
| [HighContrastSelector]: { |
Contributor
Author
There was a problem hiding this comment.
Used generic HighContrast selector as the problem was also present in High Contrast White mode.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 47f55bf:
|
Collaborator
Perf AnalysisNo significant results to display. All results
|
Asset size changes
Baseline commit: bd9d29c1617c3b2845f5e5391f25c3b8cf711821 (build) |
ecraig12345
reviewed
Jan 27, 2021
change/@fluentui-react-examples-2021-01-22-12-35-03-hotell-cherry-pick-16439.json
Outdated
Show resolved
Hide resolved
khmakoto
approved these changes
Jan 27, 2021
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
|
Can you let us know which version of fabric UI has this changes incorporated so that we could use it. |
Member
|
@v-ajrai It's in a comment just above yours.
|
2 tasks
ecraig12345
removed
the
needs cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Added a missing high contrast selector to the SplitButton styles.
Focus areas to test
CommandBar with split and disabled buttons example
Pre
Post