Skip to content

Stack/Text: Add jsxRuntime classic pragma#16863

Merged
ecraig12345 merged 3 commits into
microsoft:masterfrom
appsparkler:pragma-patch
Feb 9, 2021
Merged

Stack/Text: Add jsxRuntime classic pragma#16863
ecraig12345 merged 3 commits into
microsoft:masterfrom
appsparkler:pragma-patch

Conversation

@appsparkler

@appsparkler appsparkler commented Feb 8, 2021 •
edited by ecraig12345
Loading

Copy link
Copy Markdown

Pull request checklist

Description of changes

Added additional pragma to set runtime to classic

@appsparkler appsparkler requested a review from khmakoto as a code owner February 8, 2021 05:41
@appsparkler appsparkler mentioned this pull request Feb 8, 2021
Closed
@size-auditor

size-auditor Bot commented Feb 8, 2021 •
edited
Loading

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 107627f487bfe837f572002e04dcb7d9589a1f4e (build)

@codesandbox-ci

codesandbox-ci Bot commented Feb 8, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0dc62dd:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam

fabricteam commented Feb 8, 2021

Copy link
Copy Markdown
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 796 858 5000
BaseButtonCompat mount 926 928 5000
Breadcrumb mount 40964 41870 5000
Checkbox mount 1513 1554 5000
CheckboxBase mount 1306 1314 5000
ChoiceGroup mount 4806 4890 5000
ComboBox mount 963 1007 1000
CommandBar mount 9839 9863 1000
ContextualMenu mount 5926 5921 1000
DefaultButtonCompat mount 1170 1168 5000
DetailsRow mount 3686 3616 5000
DetailsRowFast mount 3583 3637 5000
DetailsRowNoStyles mount 3497 3479 5000
Dialog mount 1457 1525 1000
DocumentCardTitle mount 1771 1788 1000
Dropdown mount 3328 3379 5000
FocusTrapZone mount 1763 1755 5000
FocusZone mount 1749 1743 5000
IconButtonCompat mount 1801 1809 5000
Label mount 323 331 5000
Layer mount 1811 1816 5000
Link mount 448 462 5000
MakeStyles mount 1885 1893 50000
MenuButtonCompat mount 1511 1467 5000
MessageBar mount 1929 2003 5000
Nav mount 3332 3296 1000
OverflowSet mount 1056 994 5000
Panel mount 1399 1428 1000
Persona mount 833 882 1000
Pivot mount 1385 1423 1000
PrimaryButtonCompat mount 1331 1342 5000
Rating mount 7528 7763 5000
SearchBox mount 1345 1329 5000
Shimmer mount 2540 2561 5000
Slider mount 1955 1893 5000
SpinButton mount 5011 5074 5000
Spinner mount 398 383 5000
SplitButtonCompat mount 3276 3179 5000
Stack mount 495 514 5000
StackWithIntrinsicChildren mount 1573 1621 5000
StackWithTextChildren mount 4667 4737 5000
SwatchColorPicker mount 10289 10218 5000
Tabs mount 1396 1542 1000
TagPicker mount 2887 2867 5000
TeachingBubble mount 11461 11534 5000
Text mount 420 422 5000
TextField mount 1370 1368 5000
ThemeProvider mount 1357 1384 5000
ThemeProvider virtual-rerender 580 591 5000
ThemeProviderNext mount 2092 2081 5000
Toggle mount 842 782 5000
button mount 643 689 5000
buttonNative mount 106 101 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.18 0.51 0.35:1 2000 369
🦄 Button.Fluent 0.13 0.21 0.62:1 5000 627
🔧 Checkbox.Fluent 0.66 0.35 1.89:1 1000 657
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 856
🔧 Dropdown.Fluent 3.1 0.47 6.6:1 1000 3095
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 740
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 447
🔧 Slider.Fluent 1.61 0.45 3.58:1 1000 1612
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 423
🦄 Tooltip.Fluent 0.12 0.89 0.13:1 5000 576

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 263 233 1.13:1
PortalMinimalPerf.default 177 160 1.11:1
Text.Fluent 423 391 1.08:1
ButtonMinimalPerf.default 208 194 1.07:1
ButtonSlotsPerf.default 638 599 1.07:1
TextMinimalPerf.default 418 391 1.07:1
BoxMinimalPerf.default 404 380 1.06:1
LayoutMinimalPerf.default 464 438 1.06:1
TableMinimalPerf.default 460 433 1.06:1
TreeWith60ListItems.default 200 188 1.06:1
FormMinimalPerf.default 488 466 1.05:1
HeaderSlotsPerf.default 887 845 1.05:1
ListNestedPerf.default 636 605 1.05:1
Checkbox.Fluent 657 627 1.05:1
HeaderMinimalPerf.default 439 422 1.04:1
LabelMinimalPerf.default 479 461 1.04:1
ListCommonPerf.default 716 686 1.04:1
ToolbarMinimalPerf.default 1052 1012 1.04:1
CarouselMinimalPerf.default 526 509 1.03:1
ChatMinimalPerf.default 673 656 1.03:1
DialogMinimalPerf.default 834 809 1.03:1
DropdownManyItemsPerf.default 785 763 1.03:1
ImageMinimalPerf.default 429 417 1.03:1
MenuMinimalPerf.default 962 932 1.03:1
ReactionMinimalPerf.default 456 441 1.03:1
SplitButtonMinimalPerf.default 4021 3898 1.03:1
Dialog.Fluent 856 831 1.03:1
Image.Fluent 447 435 1.03:1
AccordionMinimalPerf.default 176 173 1.02:1
CardMinimalPerf.default 612 602 1.02:1
CheckboxMinimalPerf.default 2915 2848 1.02:1
FlexMinimalPerf.default 337 331 1.02:1
ItemLayoutMinimalPerf.default 1347 1315 1.02:1
TableManyItemsPerf.default 2256 2205 1.02:1
TooltipMinimalPerf.default 849 830 1.02:1
Avatar.Fluent 369 362 1.02:1
AttachmentMinimalPerf.default 187 186 1.01:1
ButtonOverridesMissPerf.default 1771 1748 1.01:1
ButtonUseCssPerf.default 870 859 1.01:1
ChatDuplicateMessagesPerf.default 382 377 1.01:1
DividerMinimalPerf.default 412 406 1.01:1
ListWith60ListItems.default 687 681 1.01:1
MenuButtonMinimalPerf.default 1657 1646 1.01:1
SegmentMinimalPerf.default 399 397 1.01:1
VideoMinimalPerf.default 712 703 1.01:1
Dropdown.Fluent 3095 3074 1.01:1
Slider.Fluent 1612 1598 1.01:1
AnimationMinimalPerf.default 430 432 1:1
DatepickerMinimalPerf.default 47973 47841 1:1
DropdownMinimalPerf.default 3047 3053 1:1
InputMinimalPerf.default 1303 1306 1:1
SkeletonMinimalPerf.default 401 402 1:1
StatusMinimalPerf.default 784 781 1:1
CustomToolbarPrototype.default 3771 3784 1:1
AttachmentSlotsPerf.default 1255 1266 0.99:1
ButtonUseCssNestingPerf.default 1123 1138 0.99:1
ChatWithPopoverPerf.default 467 470 0.99:1
EmbedMinimalPerf.default 4334 4357 0.99:1
ListMinimalPerf.default 562 570 0.99:1
LoaderMinimalPerf.default 737 747 0.99:1
ProviderMinimalPerf.default 998 1013 0.99:1
IconMinimalPerf.default 728 734 0.99:1
TreeMinimalPerf.default 872 881 0.99:1
Button.Fluent 627 631 0.99:1
Icon.Fluent 740 744 0.99:1
Tooltip.Fluent 576 582 0.99:1
GridMinimalPerf.default 379 386 0.98:1
PopupMinimalPerf.default 729 743 0.98:1
RadioGroupMinimalPerf.default 480 489 0.98:1
TextAreaMinimalPerf.default 546 555 0.98:1
RosterPerf.default 1242 1276 0.97:1
ProviderMergeThemesPerf.default 1560 1604 0.97:1
SliderMinimalPerf.default 1613 1655 0.97:1
AlertMinimalPerf.default 321 337 0.95:1
AvatarMinimalPerf.default 213 224 0.95:1

@ecraig12345 ecraig12345 changed the title Pragma patch Stack: Add jsxRuntime classic pragma Feb 9, 2021
ecraig12345
ecraig12345 approved these changes Feb 9, 2021
View reviewed changes

@ecraig12345 ecraig12345 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Comment thread change/@fluentui-react-internal-2021-02-08-11-06-00-pragma-patch.json Outdated
@ecraig12345 ecraig12345 merged commit cac130a into microsoft:master Feb 9, 2021
@ecraig12345 ecraig12345 changed the title Stack: Add jsxRuntime classic pragma Stack/Text: Add jsxRuntime classic pragma Feb 9, 2021
@ecraig12345

ecraig12345 commented Feb 9, 2021

Copy link
Copy Markdown
Member

Realized after updating the name and change description and merging this that it also changed Text, oops... I'll update the change fie at least.

@Wezea

Wezea commented Mar 9, 2021

Copy link
Copy Markdown

Will this fix be cherry-picked to v7 as well? I just ran into that issue too.

@appsparkler

appsparkler commented Mar 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Author

@Wezea, you can raise a PR as per this comment : #16678 (comment)

@Wezea Wezea mentioned this pull request Mar 9, 2021
Merged
2 tasks
@appsparkler appsparkler deleted the pragma-patch branch March 10, 2021 13:03
This was referenced Mar 10, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes
@khmakoto khmakoto Awaiting requested review from khmakoto

Assignees

@joschect joschect

Labels

Area: Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unit Test cases with Jest are failing while using office react ui fabric

6 participants

@appsparkler @fabricteam @ecraig12345 @Wezea @joschect @msft-fluent-ui-bot