Fix contrast of filter chevron against the background #16881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-fluent-ui-bot
added
the
needs cherry-pick
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 85508c3:
|
Collaborator
Perf AnalysisNo significant results to display. All results
|
Asset size changes
Baseline commit: fb40578607eb5b79d0d176cfa6caaa86eebcae09 (build) |
ecraig12345
requested changes
Feb 9, 2021
Member
ecraig12345
left a comment
ecraig12345
left a comment
There was a problem hiding this comment.
Can you please submit this to master as well? Since we're close to release, changes need to go in both branches.
dzearing
approved these changes
Feb 10, 2021
Member
|
Probably need to update-snapshots as this will change the css. |
ThomasMichon
force-pushed
the
chevron-contrast
branch
from
e973f02 to
85508c3
Compare
ecraig12345
removed
the
needs cherry-pick
ecraig12345
approved these changes
Feb 18, 2021
Collaborator
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixed the color for the 'filter chevron' to use
neutraySecondaryinstead ofneutralTertiaryto align with expected contrast requirements for accessibility. This was recommended by the Fluent Design team.