-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[7.0] Allow itemSubMenuProvider to return a boolean #17150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.0] Allow itemSubMenuProvider to return a boolean #17150
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cb7eca6:
|
Perf AnalysisNo significant results to display. All results
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f4d4223122469a5b3eeaaa1fb8fa5a8a311738a9 (build) |
|
🎉 Handy links: |
Pull request checklist
$ yarn changeDescription of changes
itemSubMenuProvider is used only for keytip code for the OverflowSet. It is used to know if an overflow item has a submenu. The function previously checked an array of "any" for existence of a submenu, however since it's just an "is defined" check a boolean works just as well. This is also needed if an overflow item's menu is deferred in any way, which means the definition of the sub menu doesn't yet exist but it should still indicate that it has a submenu
V8 change here: #17149
Focus areas to test
Added a unit test for a version of the callback that accepts a boolean