Skip to content

Conversation

@kelseyyoung
Copy link
Contributor

@kelseyyoung kelseyyoung commented Feb 23, 2021

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

itemSubMenuProvider is used only for keytip code for the OverflowSet. It is used to know if an overflow item has a submenu. The function previously checked an array of "any" for existence of a submenu, however since it's just an "is defined" check a boolean works just as well. This is also needed if an overflow item's menu is deferred in any way, which means the definition of the sub menu doesn't yet exist but it should still indicate that it has a submenu

V8 change here: #17149

Focus areas to test

Added a unit test for a version of the callback that accepts a boolean

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb7eca6:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 23, 2021

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 835 844 5000
Breadcrumb mount 39606 39478 5000
Checkbox mount 1465 1417 5000
CheckboxBase mount 1214 1179 5000
ChoiceGroup mount 4597 4610 5000
ComboBox mount 864 832 1000
CommandBar mount 7194 7166 1000
ContextualMenu mount 12551 12680 1000
DefaultButton mount 1049 1071 5000
DetailsRow mount 3315 3372 5000
DetailsRowFast mount 3350 3357 5000
DetailsRowNoStyles mount 3207 3229 5000
Dialog mount 1588 1623 1000
DocumentCardTitle mount 1697 1724 1000
Dropdown mount 2334 2361 5000
FocusTrapZone mount 1622 1579 5000
FocusZone mount 1690 1699 5000
IconButton mount 1662 1646 5000
Label mount 307 302 5000
Layer mount 1868 1824 5000
Link mount 397 411 5000
MenuButton mount 1358 1372 5000
MessageBar mount 1935 1961 5000
Nav mount 3076 3058 1000
OverflowSet mount 1307 1333 5000
Panel mount 1366 1373 1000
Persona mount 750 751 1000
Pivot mount 1333 1334 1000
PrimaryButton mount 1195 1218 5000
Rating mount 7070 7080 5000
SearchBox mount 1184 1193 5000
Shimmer mount 2368 2379 5000
Slider mount 1389 1397 5000
SpinButton mount 4691 4736 5000
Spinner mount 393 389 5000
SplitButton mount 2992 2993 5000
Stack mount 462 476 5000
StackWithIntrinsicChildren mount 1459 1462 5000
StackWithTextChildren mount 4348 4340 5000
SwatchColorPicker mount 9718 9640 5000
TagPicker mount 2571 2632 5000
TeachingBubble mount 47904 47783 5000
Text mount 406 399 5000
TextField mount 1280 1260 5000
Toggle mount 782 776 5000
button mount 106 98 5000

@size-auditor
Copy link

size-auditor bot commented Feb 23, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f4d4223122469a5b3eeaaa1fb8fa5a8a311738a9 (build)

@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 25, 2021
@kelseyyoung kelseyyoung merged commit 2dbe3cc into microsoft:7.0 Feb 25, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉office-ui-fabric-react@v7.162.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants