Skip to content

Conversation

@ecraig12345
Copy link
Member

Pull request checklist

Description of changes

All the @uifabric packages in the 7.0 branch can continue to publish under dist-tag latest since they don't exist in master. However, @fluentui packages which also exist in master must use a different dist-tag. My idea was lts-7 based on previous conventions, but I'm open to other suggestions.

Also port over the thorough cleanup and use-yarn reliability fixes from master (cherry-pick #17147), and suppress the Browserslist: caniuse-lite is outdated warning.

(Split PR/CI and better cleanup will come later, after that PR to master is done.)

const webpack = require('webpack');

// don't randomly start failing build if caniuse-lite releases a new version
process.env.BROWSERSLIST_IGNORE_OLD_DATA = '1';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 26, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ebc08a:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 26, 2021

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 1026 1042 5000
Breadcrumb mount 42231 43835 5000
Checkbox mount 1728 1685 5000
CheckboxBase mount 1497 1496 5000
ChoiceGroup mount 5383 5422 5000
ComboBox mount 985 1004 1000
CommandBar mount 8141 8255 1000
ContextualMenu mount 14395 14194 1000
DefaultButton mount 1245 1205 5000
DetailsRow mount 3793 3752 5000
DetailsRowFast mount 3938 3882 5000
DetailsRowNoStyles mount 3645 3670 5000
Dialog mount 1750 1787 1000
DocumentCardTitle mount 1837 1811 1000
Dropdown mount 2739 2741 5000
FocusTrapZone mount 1782 1775 5000
FocusZone mount 1883 1869 5000
IconButton mount 1935 1916 5000
Label mount 350 346 5000
Layer mount 2102 2032 5000
Link mount 448 459 5000
MenuButton mount 1566 1559 5000
MessageBar mount 2134 2099 5000
Nav mount 3525 3470 1000
OverflowSet mount 1459 1510 5000
Panel mount 1500 1516 1000
Persona mount 834 825 1000
Pivot mount 1478 1512 1000
PrimaryButton mount 1340 1336 5000
Rating mount 8272 8200 5000
SearchBox mount 1382 1397 5000
Shimmer mount 2736 2791 5000
Slider mount 1523 1559 5000
SpinButton mount 5374 5304 5000
Spinner mount 419 448 5000
SplitButton mount 3427 3300 5000
Stack mount 520 520 5000
StackWithIntrinsicChildren mount 1690 1705 5000
StackWithTextChildren mount 5109 5089 5000
SwatchColorPicker mount 10872 10813 5000
TagPicker mount 2907 2985 5000
TeachingBubble mount 52094 51576 5000
Text mount 451 461 5000
TextField mount 1474 1448 5000
Toggle mount 872 878 5000
button mount 107 100 5000

@size-auditor
Copy link

size-auditor bot commented Feb 26, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 824ca951620709a4a348c6d82fdb65c0c5b74cd8 (build)

@microsoft microsoft deleted a comment from ecraig12345 Feb 26, 2021
@ecraig12345 ecraig12345 merged commit deaeceb into microsoft:7.0 Feb 26, 2021
@ecraig12345 ecraig12345 deleted the 7-dist-tags branch February 26, 2021 21:02
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/theme@v1.7.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/storybook@v0.6.21 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react@v7.162.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-window-provider@v1.0.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-theme-provider@v0.18.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-stylesheets@v0.2.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-shared-contexts@v0.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-icons@v0.4.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-focus@v7.17.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-examples@v0.12.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-compose@v0.19.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-button@v0.19.6 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/eslint-plugin@v0.54.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/dom-utilities@v1.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/date-time-utilities@v7.9.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants