Adding ability to pass a Rectangle as a target and account for it in positioning logic #17468
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c416851:
|
ecraig12345
left a comment
ecraig12345
left a comment
There was a problem hiding this comment.
Approved for the hooks changes
Perf AnalysisNo significant results to display. All results
|
Asset size changes
Baseline commit: e4c63bbce6a94d8c250b7e53ceb7d13c20c85840 (build) |
JustSlone
left a comment
JustSlone
left a comment
There was a problem hiding this comment.
Can you add a quick test to cover this behavior?
(In this particular case, because it's a hotfix, if you want to follow up with a subsequent PR that's fine, just don't forget)
Also, should we add an example showing how to use rectangle and point?
|
@msft-fluent-ui-bot merge in 1 minute |
|
Hello @khmakoto! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
5 participants
Pull request checklist
$ yarn changeDescription of changes
Cherrypick of #17467
This PR adds the ability to pass a
Rectangleas one of the possibletargetsof a popup element (i.e.Callout,TeachingBubble, etc.). This is done by accounting for the fact thatRectanglesandPointshave a similar shape so we check for the existence oftopandbottomto determine if thetargetis aRectangleand, if not, we default to treating thetargetas aPoint.