Skip to content

Conversation

@TristanWatanabe
Copy link
Member

cherry-pick of #17476

Pull request checklist

Description of changes

  • Added high contrast styling to Facepile to properly display the overflow number and icons.
  • The overflow button's color is now set to be WindowText in High Contrast Mode
    ISSUE:
    issue
    FIX:
    icon-1
    icon-2
    icon-3

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit accd759:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 882 882 5000
Breadcrumb mount 41097 41667 5000
Checkbox mount 1474 1501 5000
CheckboxBase mount 1261 1269 5000
ChoiceGroup mount 4929 4767 5000
ComboBox mount 914 911 1000
CommandBar mount 7491 7662 1000
ContextualMenu mount 13698 13529 1000
DefaultButton mount 1101 1099 5000
DetailsRow mount 3498 3587 5000
DetailsRowFast mount 3491 3470 5000
DetailsRowNoStyles mount 3288 3462 5000
Dialog mount 1635 1658 1000
DocumentCardTitle mount 1813 1779 1000
Dropdown mount 2474 2504 5000
FocusTrapZone mount 1709 1654 5000
FocusZone mount 1804 1797 5000
IconButton mount 1691 1693 5000
Label mount 332 324 5000
Layer mount 1922 1874 5000
Link mount 434 440 5000
MenuButton mount 1464 1453 5000
MessageBar mount 1995 2071 5000
Nav mount 3113 3191 1000
OverflowSet mount 1355 1381 5000
Panel mount 1402 1391 1000
Persona mount 814 814 1000
Pivot mount 1404 1409 1000
PrimaryButton mount 1252 1280 5000
Rating mount 7407 7464 5000
SearchBox mount 1235 1258 5000
Shimmer mount 2507 2405 5000
Slider mount 1479 1471 5000
SpinButton mount 4914 4914 5000
Spinner mount 418 399 5000
SplitButton mount 3194 3088 5000
Stack mount 475 479 5000
StackWithIntrinsicChildren mount 1484 1450 5000
StackWithTextChildren mount 4536 4517 5000
SwatchColorPicker mount 10127 10060 5000
TagPicker mount 2712 2740 5000
TeachingBubble mount 49492 49536 5000
Text mount 418 424 5000
TextField mount 1362 1355 5000
Toggle mount 804 813 5000
button mount 98 108 5000

@size-auditor
Copy link

size-auditor bot commented Mar 18, 2021

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-Facepile 204.779 kB 204.827 kB ExceedsBaseline     48 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 7034e06e3da6bdb70433755312fde9ed7a911ddd (build)

@mtennoe mtennoe merged commit d10837a into microsoft:7.0 Mar 22, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉office-ui-fabric-react@v7.165.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/tsx-editor@v0.14.27 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/theme-samples@v7.2.26 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/react-cards@v0.115.32 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/mdl2-theme@v0.4.26 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/fluent-theme@v7.4.26 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/fabric-website@v7.16.46 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/fabric-website-resources@v7.9.45 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/experiments@v7.39.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/example-app-base@v7.18.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/date-time@v7.19.30 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/charting@v4.15.10 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/azure-themes@v7.7.20 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/api-docs@v7.6.29 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/storybook@v0.6.30 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-examples@v0.12.13 has been released which incorporates this pull request.:tada:

Handy links:

@TristanWatanabe TristanWatanabe deleted the 17182-v7 branch March 22, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants