react-accordion - Adds id control for AccordionHeader and AccordionPanel#17547
Merged
bsunderhus merged 3 commits intomasterfrom Mar 24, 2021
Merged
react-accordion - Adds id control for AccordionHeader and AccordionPanel#17547bsunderhus merged 3 commits intomasterfrom
bsunderhus merged 3 commits intomasterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8498790:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f6fdb8a4774489c354e7b0fbaec37485ffe7920b (build) |
Collaborator
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
ling1726
reviewed
Mar 24, 2021
| const expandIconPosition = useContextSelector(accordionContext, ctx => ctx.expandIconPosition); | ||
| const size = useContextSelector(accordionContext, ctx => ctx.size); | ||
| const id = useId('accordion-header-', props.id); | ||
| const panel = useDescendants(accordionItemDescendantContext)[1] as AccordionItemDescendant | undefined; |
Contributor
There was a problem hiding this comment.
You could encapsulate the usages of useDescendants with smth like useAccordionHeaderDescendant, I think it adds to some nicer readability, but it's definitely a nit
ling1726
approved these changes
Mar 24, 2021
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
…nel (microsoft#17547) * Adds id control for AccordionHeader and AccordionPanel * Updates tests * Change files
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…nel (microsoft#17547) * Adds id control for AccordionHeader and AccordionPanel * Updates tests * Change files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
A common problem on Compound Components is sharing
idinformation between siblings to ensure a11y. This PR introduces a simple usage of the descendants API to solve that.