Skip to content

Cherry pick: Fix resizing of justified columns for constrained viewport widths #18612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msft-fluent-ui-bot merged 3 commits into from
Jul 8, 2021
Merged

Cherry pick: Fix resizing of justified columns for constrained viewport widths #18612

msft-fluent-ui-bot merged 3 commits into from
Jul 8, 2021

Conversation

@sysofwan
Copy link
Contributor

@sysofwan sysofwan commented Jun 17, 2021

Pull request checklist

Description of changes

Cherrypick of PR #17374

@sysofwan sysofwan requested review from a team and ThomasMichon as code owners June 17, 2021 23:35
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 17, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f44bd95:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jun 17, 2021

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-DetailsList 217.614 kB 217.334 kB BelowBaseline     -280 bytes
office-ui-fabric-react office-ui-fabric-react-ShimmeredDetailsList 228.071 kB 227.791 kB BelowBaseline     -280 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 09a98a231db37148bb0a16b81b20d9ccd11ade39 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 17, 2021

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 1018 1002 5000
Breadcrumb mount 44405 43789 5000
Checkbox mount 1732 1736 5000
CheckboxBase mount 1463 1425 5000
ChoiceGroup mount 5677 5587 5000
ComboBox mount 1003 1023 1000
CommandBar mount 8434 8358 1000
ContextualMenu mount 15237 15156 1000
DefaultButton mount 1292 1289 5000
DetailsRow mount 4176 4261 5000
DetailsRowFast mount 4305 4225 5000
DetailsRowNoStyles mount 3976 3927 5000
Dialog mount 1910 1930 1000
DocumentCardTitle mount 2025 2003 1000
Dropdown mount 2915 2936 5000
FocusTrapZone mount 1898 1929 5000
FocusZone mount 2001 1918 5000
IconButton mount 2012 2029 5000
Label mount 374 381 5000
Layer mount 2169 2164 5000
Link mount 511 500 5000
MenuButton mount 1682 1674 5000
MessageBar mount 2235 2215 5000
Nav mount 3665 3619 1000
OverflowSet mount 1560 1554 5000
Panel mount 1624 1597 1000
Persona mount 946 931 1000
Pivot mount 1744 1712 1000
PrimaryButton mount 1592 1582 5000
Rating mount 8614 9409 5000
SearchBox mount 1434 1439 5000
Shimmer mount 2930 2870 5000
Slider mount 1661 1665 5000
SpinButton mount 5514 5521 5000
Spinner mount 432 456 5000
SplitButton mount 3545 3512 5000
Stack mount 544 544 5000
StackWithIntrinsicChildren mount 1770 1756 5000
StackWithTextChildren mount 5306 5303 5000
SwatchColorPicker mount 11383 11420 5000
TagPicker mount 3035 3052 5000
TeachingBubble mount 54555 53952 5000
Text mount 462 472 5000
TextField mount 1532 1527 5000
Toggle mount 926 917 5000
button mount 121 120 5000

@sysofwan
Copy link
Contributor Author

sysofwan commented Jun 23, 2021

@ThomasMichon Can you help review this? Simple cherry pick of PR #17374 to resolve #15971

@makislev
Copy link

makislev commented Jun 30, 2021

@ThomasMichon Can we please get some attention on this PR? this is blocking us from opening a new feature to customers

@makislev
Copy link

makislev commented Jul 7, 2021

@ThomasMichon thank you!!

@sysofwan
Copy link
Contributor Author

sysofwan commented Jul 8, 2021

@ecraig12345 can you help review the PR for cxe-red?

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jul 8, 2021

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-fluent-ui-bot) and give me an instruction to get started! Learn more here.

@msft-fluent-ui-bot msft-fluent-ui-bot merged commit 6e0f04a into microsoft:7.0 Jul 8, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jul 9, 2021

🎉office-ui-fabric-react@v7.173.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jul 9, 2021

🎉@uifabric/fabric-website@v7.16.80 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot msft-fluent-ui-bot mentioned this pull request Jul 9, 2021
Closed
@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jul 9, 2021

🎉@uifabric/fabric-website-resources@v7.9.79 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jul 9, 2021

🎉@fluentui/react-examples@v0.14.15 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomasMichon ThomasMichon ThomasMichon approved these changes

@khmakoto khmakoto khmakoto approved these changes

Assignees

@miroslavstastny miroslavstastny

Labels

AutoMerge Component: DetailsList

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sysofwan @fabricteam @makislev @msft-fluent-ui-bot @ThomasMichon @khmakoto @miroslavstastny