Skip to content

fix(accordion): Migrate to useControllableState hook#19094

Merged
bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus:react-accordion-use-controllable
Jul 23, 2021
Merged

fix(accordion): Migrate to useControllableState hook#19094
bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus:react-accordion-use-controllable

Conversation

@bsunderhus
Copy link
Copy Markdown
Contributor

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Migrates from useControllableValue to useControllableState

@bsunderhus bsunderhus enabled auto-merge (squash) July 23, 2021 08:33
@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f6e563b:

Sandbox Source
Fluent UI React Starter Configuration

@fabricteam
Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
78.581 kB
23.243 kB
78.492 kB
23.211 kB
89 B
32 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
196.917 kB
57.637 kB
196.889 kB
57.626 kB
28 B
11 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: FluentProvider & webLightTheme
35.659 kB
11.467 kB
🤖 This report was generated against 8c249a1c1a8dcc4b0d9877e5d5e8e6d126063788

@size-auditor
Copy link
Copy Markdown

size-auditor bot commented Jul 23, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8c249a1c1a8dcc4b0d9877e5d5e8e6d126063788 (build)

@fabricteam
Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 844 847 5000
BaseButton mount 954 919 5000
Breadcrumb mount 2700 2676 1000
ButtonNext mount 461 469 5000
Checkbox mount 1718 1743 5000
CheckboxBase mount 1453 1491 5000
ChoiceGroup mount 5210 5113 5000
ComboBox mount 1057 1055 1000
CommandBar mount 10282 10600 1000
ContextualMenu mount 6369 6123 1000
DefaultButton mount 1185 1211 5000
DetailsRow mount 4113 3874 5000
DetailsRowFast mount 3869 3884 5000
DetailsRowNoStyles mount 3678 3730 5000
Dialog mount 2183 2225 1000
DocumentCardTitle mount 150 156 1000
Dropdown mount 3509 3412 5000
FluentProviderNext mount 6949 6895 5000
FocusTrapZone mount 1850 1867 5000
FocusZone mount 1889 1865 5000
IconButton mount 2010 1869 5000
Label mount 355 354 5000
Layer mount 1893 1876 5000
Link mount 486 486 5000
MakeStyles mount 1786 1828 50000
MenuButton mount 1561 1583 5000
MessageBar mount 2022 2013 5000
Nav mount 3421 3394 1000
OverflowSet mount 1097 1084 5000
Panel mount 2169 2133 1000
Persona mount 896 896 1000
Pivot mount 1517 1547 1000
PrimaryButton mount 1348 1363 5000
Rating mount 8151 8181 5000
SearchBox mount 1452 1421 5000
Shimmer mount 2681 2767 5000
Slider mount 2088 2003 5000
SpinButton mount 5384 5222 5000
Spinner mount 435 445 5000
SplitButton mount 3308 3396 5000
Stack mount 532 538 5000
StackWithIntrinsicChildren mount 1654 1697 5000
StackWithTextChildren mount 4920 5004 5000
SwatchColorPicker mount 10856 10674 5000
Tabs mount 1441 1476 1000
TagPicker mount 2559 2651 5000
TeachingBubble mount 12241 12205 5000
Text mount 441 439 5000
TextField mount 1402 1429 5000
ThemeProvider mount 1206 1175 5000
ThemeProvider virtual-rerender 605 601 5000
Toggle mount 859 872 5000
buttonNative mount 121 113 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 182 155 1.17:1
PortalMinimalPerf.default 186 165 1.13:1
VideoMinimalPerf.default 728 658 1.11:1
AvatarMinimalPerf.default 226 210 1.08:1
TextAreaMinimalPerf.default 590 545 1.08:1
GridMinimalPerf.default 394 367 1.07:1
RadioGroupMinimalPerf.default 506 474 1.07:1
HeaderMinimalPerf.default 401 377 1.06:1
AlertMinimalPerf.default 314 300 1.05:1
LabelMinimalPerf.default 427 405 1.05:1
TableMinimalPerf.default 435 416 1.05:1
TextMinimalPerf.default 375 358 1.05:1
ButtonSlotsPerf.default 589 566 1.04:1
ChatDuplicateMessagesPerf.default 304 291 1.04:1
DropdownManyItemsPerf.default 732 705 1.04:1
SegmentMinimalPerf.default 393 379 1.04:1
ChatWithPopoverPerf.default 406 396 1.03:1
CheckboxMinimalPerf.default 2955 2882 1.03:1
RefMinimalPerf.default 245 239 1.03:1
SkeletonMinimalPerf.default 403 393 1.03:1
SplitButtonMinimalPerf.default 4134 4028 1.03:1
TableManyItemsPerf.default 2090 2030 1.03:1
AnimationMinimalPerf.default 448 439 1.02:1
ButtonMinimalPerf.default 185 181 1.02:1
ButtonOverridesMissPerf.default 1763 1733 1.02:1
DatepickerMinimalPerf.default 5702 5566 1.02:1
EmbedMinimalPerf.default 4317 4237 1.02:1
InputMinimalPerf.default 1328 1297 1.02:1
LayoutMinimalPerf.default 391 382 1.02:1
ListMinimalPerf.default 536 523 1.02:1
MenuButtonMinimalPerf.default 1748 1714 1.02:1
TreeWith60ListItems.default 207 203 1.02:1
BoxMinimalPerf.default 373 369 1.01:1
CardMinimalPerf.default 589 583 1.01:1
DropdownMinimalPerf.default 3151 3119 1.01:1
FormMinimalPerf.default 451 447 1.01:1
MenuMinimalPerf.default 893 888 1.01:1
ProviderMinimalPerf.default 1043 1032 1.01:1
ReactionMinimalPerf.default 412 406 1.01:1
StatusMinimalPerf.default 728 722 1.01:1
CustomToolbarPrototype.default 3976 3938 1.01:1
AttachmentSlotsPerf.default 1144 1146 1:1
DialogMinimalPerf.default 785 782 1:1
HeaderSlotsPerf.default 818 820 1:1
ImageMinimalPerf.default 400 401 1:1
ItemLayoutMinimalPerf.default 1326 1324 1:1
LoaderMinimalPerf.default 712 712 1:1
TreeMinimalPerf.default 854 855 1:1
ChatMinimalPerf.default 683 692 0.99:1
DividerMinimalPerf.default 372 375 0.99:1
ListNestedPerf.default 581 585 0.99:1
ListWith60ListItems.default 675 680 0.99:1
ProviderMergeThemesPerf.default 1606 1630 0.99:1
SliderMinimalPerf.default 1667 1681 0.99:1
TooltipMinimalPerf.default 1069 1081 0.99:1
CarouselMinimalPerf.default 469 480 0.98:1
ToolbarMinimalPerf.default 968 990 0.98:1
AccordionMinimalPerf.default 164 171 0.96:1
FlexMinimalPerf.default 302 315 0.96:1
ListCommonPerf.default 664 701 0.95:1
PopupMinimalPerf.default 585 617 0.95:1
RosterPerf.default 1226 1304 0.94:1
IconMinimalPerf.default 657 702 0.94:1

@bsunderhus bsunderhus merged commit 68f0838 into microsoft:master Jul 23, 2021
@msft-fluent-ui-bot
Copy link
Copy Markdown
Collaborator

🎉@fluentui/react-accordion@v9.0.0-alpha.57 has been released which incorporates this pull request.:tada:

Handy links:

PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
* Migrate to useControllableState hook

* Change files
@bsunderhus bsunderhus deleted the react-accordion-use-controllable branch June 20, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants