Skip to content

Text - Migration guide#19120

Merged
theerebuss merged 20 commits intomicrosoft:masterfrom
theerebuss:text-migration-doc
Aug 11, 2021
Merged

Text - Migration guide#19120
theerebuss merged 20 commits intomicrosoft:masterfrom
theerebuss:text-migration-doc

Conversation

@theerebuss
Copy link
Copy Markdown
Contributor

@theerebuss theerebuss commented Jul 23, 2021

Pull request checklist

- Addresses an existing issue: Fixes #0000
- Include a change request file using $ yarn change

Description of changes

Migration guide for react-text

Focus areas to test

PREVIEW

tringakrasniqi and others added 4 commits July 23, 2021 15:16
Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
Add deprecation notice
Add link to size table for N*

Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
@fabricteam
Copy link
Copy Markdown
Collaborator

fabricteam commented Jul 23, 2021

📊 Bundle size report

🤖 This report was generated against cb38c2453ce8de979b54c8cebc1b4763bf67d541

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Jul 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c87e74b:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link
Copy Markdown

size-auditor Bot commented Jul 23, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cb38c2453ce8de979b54c8cebc1b4763bf67d541 (build)

@fabricteam
Copy link
Copy Markdown
Collaborator

fabricteam commented Jul 23, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 849 850 5000
BaseButton mount 852 849 5000
Breadcrumb mount 2494 2508 1000
ButtonNext mount 386 399 5000
Checkbox mount 1399 1392 5000
CheckboxBase mount 1223 1241 5000
ChoiceGroup mount 4439 4449 5000
ComboBox mount 932 947 1000
CommandBar mount 9571 9632 1000
ContextualMenu mount 5733 5732 1000
DefaultButton mount 1051 1054 5000
DetailsRow mount 3510 3586 5000
DetailsRowFast mount 3493 3538 5000
DetailsRowNoStyles mount 3304 3357 5000
Dialog mount 2008 2015 1000
DocumentCardTitle mount 132 141 1000
Dropdown mount 3026 3049 5000
FluentProviderNext mount 7046 7216 5000
FocusTrapZone mount 1692 1701 5000
FocusZone mount 1718 1721 5000
IconButton mount 1612 1613 5000
Label mount 310 315 5000
Layer mount 1673 1667 5000
Link mount 436 421 5000
MakeStyles mount 1725 1716 50000
MenuButton mount 1352 1369 5000
MessageBar mount 1886 1898 5000
Nav mount 3068 3090 1000
OverflowSet mount 989 964 5000
Panel mount 1958 1982 1000
Persona mount 756 772 1000
Pivot mount 1313 1322 1000
PrimaryButton mount 1185 1197 5000
Rating mount 7284 7154 5000
SearchBox mount 1214 1252 5000
Shimmer mount 2401 2360 5000
Slider mount 1819 1783 5000
SpinButton mount 4683 4696 5000
Spinner mount 392 395 5000
SplitButton mount 2900 2980 5000
Stack mount 471 460 5000
StackWithIntrinsicChildren mount 1439 1427 5000
StackWithTextChildren mount 4237 4215 5000
SwatchColorPicker mount 9618 9588 5000
Tabs mount 1297 1315 1000
TagPicker mount 2406 2419 5000
TeachingBubble mount 11249 11182 5000
Text mount 387 390 5000
TextField mount 1310 1319 5000
ThemeProvider mount 1105 1109 5000
ThemeProvider virtual-rerender 559 564 5000
Toggle mount 786 757 5000
buttonNative mount 114 106 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 147 128 1.15:1
AttachmentMinimalPerf.default 150 134 1.12:1
DividerMinimalPerf.default 349 326 1.07:1
SkeletonMinimalPerf.default 339 318 1.07:1
ButtonSlotsPerf.default 519 489 1.06:1
BoxMinimalPerf.default 328 313 1.05:1
GridMinimalPerf.default 320 306 1.05:1
ListNestedPerf.default 524 497 1.05:1
ListWith60ListItems.default 604 577 1.05:1
SegmentMinimalPerf.default 327 312 1.05:1
CardMinimalPerf.default 517 496 1.04:1
ChatMinimalPerf.default 606 582 1.04:1
DialogMinimalPerf.default 725 699 1.04:1
ImageMinimalPerf.default 353 340 1.04:1
ListCommonPerf.default 582 562 1.04:1
ReactionMinimalPerf.default 354 342 1.04:1
AnimationMinimalPerf.default 391 378 1.03:1
AttachmentSlotsPerf.default 1028 1002 1.03:1
MenuMinimalPerf.default 783 759 1.03:1
ProviderMergeThemesPerf.default 1597 1558 1.03:1
VideoMinimalPerf.default 576 561 1.03:1
FlexMinimalPerf.default 267 263 1.02:1
ItemLayoutMinimalPerf.default 1134 1117 1.02:1
ListMinimalPerf.default 469 460 1.02:1
PopupMinimalPerf.default 569 558 1.02:1
ProviderMinimalPerf.default 939 918 1.02:1
TreeWith60ListItems.default 164 161 1.02:1
DatepickerMinimalPerf.default 5160 5090 1.01:1
FormMinimalPerf.default 370 368 1.01:1
HeaderSlotsPerf.default 696 686 1.01:1
LabelMinimalPerf.default 356 353 1.01:1
LayoutMinimalPerf.default 340 336 1.01:1
LoaderMinimalPerf.default 649 643 1.01:1
TextAreaMinimalPerf.default 454 451 1.01:1
ToolbarMinimalPerf.default 869 863 1.01:1
TooltipMinimalPerf.default 951 937 1.01:1
AlertMinimalPerf.default 257 258 1:1
CarouselMinimalPerf.default 422 424 1:1
CheckboxMinimalPerf.default 2574 2574 1:1
DropdownMinimalPerf.default 2923 2911 1:1
EmbedMinimalPerf.default 3852 3848 1:1
MenuButtonMinimalPerf.default 1526 1527 1:1
RosterPerf.default 1082 1086 1:1
RadioGroupMinimalPerf.default 415 413 1:1
SplitButtonMinimalPerf.default 3550 3533 1:1
TextMinimalPerf.default 311 312 1:1
CustomToolbarPrototype.default 3634 3628 1:1
TreeMinimalPerf.default 737 734 1:1
ButtonOverridesMissPerf.default 1594 1613 0.99:1
DropdownManyItemsPerf.default 634 638 0.99:1
HeaderMinimalPerf.default 326 328 0.99:1
InputMinimalPerf.default 1165 1171 0.99:1
RefMinimalPerf.default 220 223 0.99:1
SliderMinimalPerf.default 1447 1462 0.99:1
IconMinimalPerf.default 556 563 0.99:1
TableManyItemsPerf.default 1750 1772 0.99:1
TableMinimalPerf.default 372 376 0.99:1
ChatDuplicateMessagesPerf.default 267 273 0.98:1
PortalMinimalPerf.default 168 172 0.98:1
ButtonMinimalPerf.default 154 158 0.97:1
AvatarMinimalPerf.default 177 184 0.96:1
StatusMinimalPerf.default 617 647 0.95:1
ChatWithPopoverPerf.default 320 340 0.94:1

@theerebuss theerebuss marked this pull request as ready for review August 10, 2021 09:08
@theerebuss theerebuss requested a review from a team as a code owner August 10, 2021 09:08
@theerebuss theerebuss requested review from a team August 10, 2021 09:08
@theerebuss theerebuss merged commit 477b0b2 into microsoft:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants