Skip to content

Conversation

@khmakoto
Copy link
Member

@khmakoto khmakoto commented Nov 4, 2021

Pull request checklist

Description of changes

Port of #20488. Original description follows:

This PR makes the disabled prop in IDetailsRowStyleProps optional as it was introduced as an unintended breaking change by making it required.

…al as making it required is a breaking change.
@khmakoto khmakoto requested a review from a team November 4, 2021 02:07
@khmakoto khmakoto self-assigned this Nov 4, 2021
@msft-fluent-ui-bot msft-fluent-ui-bot added Fabric 7 PR: API Modified needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master labels Nov 4, 2021
Copy link
Collaborator

@msft-fluent-ui-bot msft-fluent-ui-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).

Please do one of the following:

  • If you've already created a PR to master, add a link to it
  • If the change is irrelevant to version 8, add a comment explaining why
  • Otherwise, create a PR to master with this same change, and add a link to it

After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).

Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).

@khmakoto khmakoto removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Nov 4, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 4, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c19b28:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Nov 4, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 65c2c97966c75641a4c7bed4f0e7fffce8d248bb (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 934 895 5000
Breadcrumb mount 41081 41481 5000
Checkbox mount 1514 1540 5000
CheckboxBase mount 1264 1285 5000
ChoiceGroup mount 4879 4988 5000
ComboBox mount 910 891 1000
CommandBar mount 7687 7755 1000
ContextualMenu mount 13582 13758 1000
DefaultButton mount 1124 1111 5000
DetailsRow mount 3677 3785 5000
DetailsRowFast mount 3740 3764 5000
DetailsRowNoStyles mount 3567 3492 5000
Dialog mount 1738 1731 1000
DocumentCardTitle mount 1844 1820 1000
Dropdown mount 2409 2459 5000
FocusTrapZone mount 1683 1704 5000
FocusZone mount 1760 1839 5000
IconButton mount 1790 1729 5000
Label mount 341 338 5000
Layer mount 1946 1923 5000
Link mount 445 453 5000
MenuButton mount 1471 1514 5000
MessageBar mount 2110 2046 5000
Nav mount 3267 3361 1000
OverflowSet mount 1388 1392 5000
Panel mount 1429 1495 1000
Persona mount 796 770 1000
Pivot mount 1440 1478 1000
PrimaryButton mount 1261 1289 5000
Rating mount 7987 7916 5000
SearchBox mount 1289 1267 5000
Shimmer mount 2649 2483 5000
Slider mount 1502 1511 5000
SpinButton mount 5047 5003 5000
Spinner mount 428 417 5000
SplitButton mount 3147 3203 5000
Stack mount 499 517 5000
StackWithIntrinsicChildren mount 1637 1677 5000
StackWithTextChildren mount 4775 4809 5000
SwatchColorPicker mount 10542 10670 5000
TagPicker mount 2855 2845 5000
TeachingBubble mount 50089 50618 5000
Text mount 420 451 5000
TextField mount 1376 1379 5000
Toggle mount 847 829 5000
button mount 111 109 5000

@ecraig12345 ecraig12345 merged commit 060a8a3 into microsoft:7.0 Nov 4, 2021
@mltejera
Copy link
Contributor

mltejera commented Nov 4, 2021

Thanks again Elizabeth and Makoto!

@khmakoto khmakoto deleted the detailsRowDisabledOption7.0 branch November 5, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants