Fix FocusZone to stop eating spacebars in textarea#2054
Merged
dzearing merged 1 commit intomicrosoft:masterfrom Jun 23, 2017
antonf:fix-focuszone-textarea
Merged
Fix FocusZone to stop eating spacebars in textarea#2054dzearing merged 1 commit intomicrosoft:masterfrom antonf:fix-focuszone-textarea
dzearing merged 1 commit intomicrosoft:masterfrom
antonf:fix-focuszone-textarea
Conversation
|
@antonf, It will cover your contributions to all Microsoft-managed open source projects. |
|
@antonf, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
dzearing
approved these changes
Jun 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Addresses an existing issue: Fixes #2053
Description of changes
FocusZone._tryInvokeClickForFocusable should abort not only for tags, but also for <textarea> tag targets.
Modified _isElementInput which should treat textarea as input element also.
Focus areas to test
Check that spaces are inserted into textarea: https://codepen.io/antonf/pen/RgZbpO