Skip to content

react-accordion: Replacing use of functions in makeStyles with direct use of tokens#21033

Closed
khmakoto wants to merge 4 commits intomicrosoft:masterfrom
khmakoto:noFunctionsInMakeStylesReactAccordion
Closed

react-accordion: Replacing use of functions in makeStyles with direct use of tokens#21033
khmakoto wants to merge 4 commits intomicrosoft:masterfrom
khmakoto:noFunctionsInMakeStylesReactAccordion

Conversation

@khmakoto
Copy link
Copy Markdown
Member

Pull request checklist

Description of changes

This PR follows #21026.

This PR replaces the use of functions in makeStyles calls in the react-accordion package with direct use of the tokens exported from @fluentui/react-theme.

@khmakoto khmakoto self-assigned this Dec 15, 2021
@fabricteam
Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-make-styles
makeStaticStyles (runtime)
7.602 kB
3.325 kB
react-make-styles
makeStyles + mergeClasses (runtime)
22.006 kB
8.311 kB
react-make-styles
makeStyles + mergeClasses (build time)
2.689 kB
1.23 kB
react-theme
Teams: all themes
29.344 kB
6.55 kB
react-theme
Teams: Light theme
18.4 kB
5.273 kB
🤖 This report was generated against 28ceaaa83cd92a0389c466f0b15b283e3d9b08e4

@size-auditor
Copy link
Copy Markdown

size-auditor Bot commented Dec 15, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 28ceaaa83cd92a0389c466f0b15b283e3d9b08e4 (build)

@khmakoto khmakoto closed this Dec 15, 2021
@khmakoto khmakoto deleted the noFunctionsInMakeStylesReactAccordion branch December 15, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants