Skip to content

[cherrypick] Fix onRenderDetailsGroupHeader props for custom group.onRenderHeader #21148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
micahgodbolt merged 5 commits into from
Jan 28, 2022
Merged

[cherrypick] Fix onRenderDetailsGroupHeader props for custom group.onRenderHeader #21148

micahgodbolt merged 5 commits into from
Jan 28, 2022

Conversation

@shre-verse
Copy link
Member

@shre-verse shre-verse commented Jan 3, 2022

Pull request checklist

Description of changes

Cherry-pick #18101

@shre-verse
Fix onRenderDetailsGroupHeader props for custom group.onRenderHeader (m…
ce79f3b 
…icrosoft#18101)

* Fix onRenderDetailsGroupHeader props

* Update example to check checkboxVisibility values

* Change files

* Update @fluentui-react-examples-a5ce8de6-7c81-46f1-89ae-aade2984222c.json

* Address PR comments

* Fix PR comments

* Update example snapshot

* Fix build issue

* Fix example snapshot
@shre-verse
Change files
172e00e
@shre-verse
Pass checkboxVisiblity to DetailsList in example
782e108
@shre-verse shre-verse requested review from a team and ThomasMichon as code owners January 3, 2022 10:48
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 3, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 34ca74f:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui Configuration

@size-auditor
Copy link

size-auditor bot commented Jan 3, 2022 •
edited
Loading

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-ShimmeredDetailsList 230.286 kB 230.308 kB ExceedsBaseline     22 bytes
office-ui-fabric-react office-ui-fabric-react-DetailsList 219.831 kB 219.852 kB ExceedsBaseline     21 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: db36faba69424fc72747b39f1e68408741ceb80c (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 3, 2022 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 1014 1020 5000
Breadcrumb mount 43797 44100 5000
Checkbox mount 1782 1824 5000
CheckboxBase mount 1458 1523 5000
ChoiceGroup mount 5570 5601 5000
ComboBox mount 958 995 1000
CommandBar mount 8193 8245 1000
ContextualMenu mount 14340 14396 1000
DefaultButton mount 1237 1255 5000
DetailsRow mount 3993 4010 5000
DetailsRowFast mount 4109 4004 5000
DetailsRowNoStyles mount 3877 3834 5000
Dialog mount 1877 1865 1000
DocumentCardTitle mount 1882 1925 1000
Dropdown mount 2789 2670 5000
FocusTrapZone mount 1820 1833 5000
FocusZone mount 1869 1818 5000
IconButton mount 1930 1965 5000
Label mount 387 360 5000
Layer mount 2147 2214 5000
Link mount 530 500 5000
MenuButton mount 1689 1660 5000
MessageBar mount 2219 2254 5000
Nav mount 3686 3587 1000
OverflowSet mount 1553 1543 5000
Panel mount 1599 1579 1000
Persona mount 883 893 1000
Pivot mount 1625 1588 1000
PrimaryButton mount 1464 1486 5000
Rating mount 8990 8990 5000
SearchBox mount 1440 1496 5000
Shimmer mount 2934 2880 5000
Slider mount 1687 1694 5000
SpinButton mount 5568 5576 5000
Spinner mount 447 429 5000
SplitButton mount 3474 3562 5000
Stack mount 541 553 5000
StackWithIntrinsicChildren mount 2011 1918 5000
StackWithTextChildren mount 5628 5544 5000
SwatchColorPicker mount 11945 11693 5000
TagPicker mount 3071 3224 5000
TeachingBubble mount 52301 50449 5000
Text mount 473 447 5000
TextField mount 1447 1443 5000
Toggle mount 877 890 5000
button mount 100 99 5000

@shre-verse
Copy link
Member Author

shre-verse commented Jan 10, 2022

@ecraig12345 Requesting help with this.

@shre-verse
Copy link
Member Author

shre-verse commented Jan 12, 2022

@micahgodbolt requesting help with this.

@shre-verse
Copy link
Member Author

shre-verse commented Jan 19, 2022

@ThomasMichon Can you please help here?

micahgodbolt
micahgodbolt approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@micahgodbolt micahgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to re-run CI to get screener to pass

@shre-verse
Copy link
Member Author

shre-verse commented Jan 28, 2022

@micahgodbolt Thanks for approving this. This looks ready to merge now. Can you please help ?

@micahgodbolt micahgodbolt merged commit a852a22 into microsoft:7.0 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micahgodbolt micahgodbolt micahgodbolt approved these changes

@ThomasMichon ThomasMichon Awaiting requested review from ThomasMichon ThomasMichon is a code owner

Assignees

@spmonahan spmonahan

Labels

Component: DetailsList

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shre-verse @fabricteam @micahgodbolt @msft-fluent-ui-bot @spmonahan @ecraig12345