Skip to content

Conversation

@micahgodbolt
Copy link
Member

Cherry-pick from #22200

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6f552e0:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 30, 2022

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-Pickers 282.93 kB 283.052 kB ExceedsBaseline     122 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 219b79b940d240ff28f65c13e0661d0ee11de78f (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 742 765 5000
Breadcrumb mount 36030 33994 5000
Checkbox mount 1303 1269 5000
CheckboxBase mount 1052 1083 5000
ChoiceGroup mount 4029 4184 5000
ComboBox mount 740 710 1000
CommandBar mount 6547 6631 1000
ContextualMenu mount 12659 12480 1000
DefaultButton mount 966 967 5000
DetailsRow mount 3129 3190 5000
DetailsRowFast mount 3033 3215 5000
DetailsRowNoStyles mount 8023 3018 5000
Dialog mount 1461 1472 1000
DocumentCardTitle mount 1542 1541 1000
Dropdown mount 2042 2038 5000
FocusTrapZone mount 1301 1491 5000
FocusZone mount 1586 1493 5000
IconButton mount 1471 1402 5000
Label mount 283 267 5000
Layer mount 1628 1592 5000
Link mount 362 324 5000
MenuButton mount 1247 1236 5000
MessageBar mount 1669 1757 5000
Nav mount 2720 2735 1000
OverflowSet mount 1200 1173 5000
Panel mount 1238 1243 1000
Persona mount 655 687 1000
Pivot mount 1236 1261 1000
PrimaryButton mount 1059 1000 5000
Rating mount 6252 6421 5000
SearchBox mount 1033 1059 5000
Shimmer mount 2231 2119 5000
Slider mount 1240 1286 5000
SpinButton mount 4124 4253 5000
Spinner mount 360 358 5000
SplitButton mount 2683 2700 5000
Stack mount 426 417 5000
StackWithIntrinsicChildren mount 1326 1427 5000
StackWithTextChildren mount 3959 3946 5000
SwatchColorPicker mount 8651 8891 5000
TagPicker mount 2392 2393 5000
TeachingBubble mount 39744 42924 5000
Text mount 317 363 5000
TextField mount 1028 1176 5000
Toggle mount 705 687 5000
button mount 100 89 5000

@micahgodbolt
Copy link
Member Author

oh fun. unrelated screener failures

@ecraig12345
Copy link
Member

oh fun. unrelated screener failures

v7 has been having some screener reliability problems--I think it needs image fixes ported from master.

@Hotell Hotell removed their assignment Mar 31, 2022
@micahgodbolt micahgodbolt merged commit e5cd841 into microsoft:7.0 Mar 31, 2022
@micahgodbolt micahgodbolt deleted the people-picker-secondary-text-color-v7 branch March 31, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants