Skip to content

ARIA input field does not have an accessible name issue#22420

Merged
AtishayMsft merged 8 commits intomicrosoft:masterfrom
AnnapareddyHarsha:Harsha_fluentui
Apr 20, 2022
Merged

ARIA input field does not have an accessible name issue#22420
AtishayMsft merged 8 commits intomicrosoft:masterfrom
AnnapareddyHarsha:Harsha_fluentui

Conversation

@AnnapareddyHarsha
Copy link
Copy Markdown
Contributor

@AnnapareddyHarsha AnnapareddyHarsha commented Apr 8, 2022

Current Behavior

ARIA input field does not have an accessible name, Id attribute values are not unique,
When focus is on any graph element, screen reader announces graphic clickable.

New Behavior

While I am checking by using accessibility we are getting this error(Please find in attached Screen shot). After this fix I checked again by using accessibility we are not getting that error.

Related Issue(s)

ARIA input field does not have an accessible name issue.

Id attribute values are not unique.
When focus is on any graph element, screen reader announces graphic clickable.

Fixes #
Code changes for ARIA input field does not have an accessible name, Id attribute values are not unique,
When focus is on any graph element, screen reader announces graphic clickable. After this code It is working fine as epected.

Files changes in
AreaChat, Grouped StackBar chat and vertical StackBar chat.

@ghost
Copy link
Copy Markdown

ghost commented Apr 8, 2022

CLA assistant check
All CLA requirements met.

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Apr 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f3ef186:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Copy Markdown
Collaborator

fabricteam commented Apr 8, 2022

📊 Bundle size report

🤖 This report was generated against d1ac3a2a447caff9c48724a964cf736d4b2678ce

@AtishayMsft AtishayMsft self-requested a review April 8, 2022 08:26
@size-auditor
Copy link
Copy Markdown

size-auditor bot commented Apr 8, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d1ac3a2a447caff9c48724a964cf736d4b2678ce (build)

@Hotell
Copy link
Copy Markdown
Contributor

Hotell commented Apr 11, 2022

can you provide proper PR description as well please like to demonstrate existing behaviour and what's the changed one ?

thanks!

@Hotell Hotell removed their assignment Apr 11, 2022
@Hotell Hotell added the Fluent UI react (v8) Issues about @fluentui/react (v8) label Apr 11, 2022
@AnnapareddyHarsha
Copy link
Copy Markdown
Contributor Author

Code changes for ARIA input field does not have an accessible name, Id attribute values are not unique.
When focus is on any graph element, screen reader announces graphic clickable for Vertical Stack Bar and Grouped Vertical Bar Chat and Area Chat.

@AnnapareddyHarsha
Copy link
Copy Markdown
Contributor Author

@Hotell Please review this PR. Followed your comments and Changes are made related to

ARIA input field does not have an accessible name, Id attribute values are not unique,
When focus is on any graph element, screen reader announces graphic clickable.

Changed Files are related to Vertical Stack Bar and Grouped Vertical Bar Chat and Area Chat.

@AnnapareddyHarsha
Copy link
Copy Markdown
Contributor Author

While I am checking by using accessibility we are getting this error(Please find in attached Screen shot). After this fix I checked again by using accessibility we are not getting that error.

image

@AtishayMsft AtishayMsft merged commit 43f3fbf into microsoft:master Apr 20, 2022
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
)

* ARIA input field does not have an accessible name, Id attribute values are not unique,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Website Fluent UI react (v8) Issues about @fluentui/react (v8)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants