Cherry Pick: DetailsList isSelectedOnFocus #23548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: Cherry-pick from master branch. Adds a new optional prop, `isSelectedOnFocus` to DetailsList to control whether items in the list are selected on focus. By default the value for this prop is `true` and the existing behavior of DetailsList is preserved. When setting this value to `false` the behavior in `onHeaderKeyDown` is changed so that using the down arrow key to move from the header row to the list proper will _not_ select the first item in the list. When `isSelectedOnFocus` is set to `true` the first item in the list will _always_ be selected (this is the behavior prior to this change). Additionally, this prop is passed down to DetailsList's internal SelectionZone as this prop also exists on that component. Previously users could only pass this prop via the `selectionZoneProps` prop on DetailsList. The default behavior for SelectionZone is also maintained as the default value for its `isSelectedOnFocus` prop is also `true`.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 39af26b:
|
Asset size changes
Baseline commit: 442e3fe9e02b8b858b8bd7ffa7a7fb27ac1a2222 (build) |
Collaborator
Perf AnalysisNo significant results to display. All results
|
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
sopranopillow
approved these changes
Jun 15, 2022
change/@fluentui-react-1c69b2a4-8b4f-43fd-bfb9-02d2307b9b4b.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com>
khmakoto
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks a change to DetailsList from
masterthat addsisSelectedOnFocus.Original pull request: #23467