Skip to content

Conversation

@khmakoto
Copy link
Member

PR Description

This PR is a cherrypick of #18469 to the 7.0 branch.

Original PR description follows:

Currently, the tooltip/truncation behavior in Persona means we have tooltips within the dropdown of PeoplePicker. To fix that, I've made these changes:

  • Add a showOverflowTooltip prop to Persona that defaults to true (the current behavior)
  • Set showOverflowTooltip to false on the Persona used within PeoplePicker
  • Update the List example of PeoplePicker to demo styles for wrapping text instead of truncating
  • Add docs wording to Persona and PeoplePicker about the changes

Related Issue(s)

Fixes #23480

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cc0b74e:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jun 29, 2022

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-Pickers 282.714 kB 282.961 kB ExceedsBaseline     247 bytes
office-ui-fabric-react office-ui-fabric-react-FloatingPicker 238.094 kB 238.318 kB ExceedsBaseline     224 bytes
office-ui-fabric-react office-ui-fabric-react-SelectedItemsList 227.556 kB 227.78 kB ExceedsBaseline     224 bytes
office-ui-fabric-react office-ui-fabric-react-Facepile 207.856 kB 208.08 kB ExceedsBaseline     224 bytes
office-ui-fabric-react office-ui-fabric-react-PersonaCoin 113.878 kB 114.102 kB ExceedsBaseline     224 bytes
office-ui-fabric-react office-ui-fabric-react-Persona 113.878 kB 114.102 kB ExceedsBaseline     224 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 88e21b0512420456f96b83c0742431b42db89374 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 791 770 5000
Breadcrumb mount 34840 34383 5000
Checkbox mount 1275 1291 5000
CheckboxBase mount 1086 1064 5000
ChoiceGroup mount 3989 4088 5000
ComboBox mount 705 710 1000
CommandBar mount 6530 6549 1000
ContextualMenu mount 11844 11719 1000
DefaultButton mount 921 936 5000
DetailsRow mount 3031 2983 5000
DetailsRowFast mount 2969 2952 5000
DetailsRowNoStyles mount 2861 2844 5000
Dialog mount 1859 1852 1000
DocumentCardTitle mount 1507 1504 1000
Dropdown mount 2059 2049 5000
FocusTrapZone mount 1416 1444 5000
FocusZone mount 1544 1493 5000
IconButton mount 1376 1353 5000
Label mount 308 311 5000
Layer mount 1616 1645 5000
Link mount 398 402 5000
MenuButton mount 1201 1195 5000
MessageBar mount 1777 1812 5000
Nav mount 2580 2620 1000
OverflowSet mount 1216 1195 5000
Panel mount 1170 1200 1000
Persona mount 786 812 1000
Pivot mount 1113 1116 1000
PrimaryButton mount 1066 1043 5000
Rating mount 6667 6697 5000
SearchBox mount 1064 1071 5000
Shimmer mount 2243 2253 5000
Slider mount 1288 1299 5000
SpinButton mount 3910 3988 5000
Spinner mount 387 380 5000
SplitButton mount 2457 2448 5000
Stack mount 461 461 5000
StackWithIntrinsicChildren mount 1378 1394 5000
StackWithTextChildren mount 4279 4302 5000
SwatchColorPicker mount 8118 8134 5000
TagPicker mount 2111 2157 5000
TeachingBubble mount 41154 41331 5000
Text mount 401 407 5000
TextField mount 1149 1144 5000
Toggle mount 748 731 5000
button mount 94 89 5000

@khmakoto khmakoto merged commit 49fd50d into microsoft:7.0 Jun 29, 2022
@khmakoto khmakoto deleted the personaTooltipOptional branch June 29, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants