-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Added exports for decorators missing from v7 #24097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added exports for decorators missing from v7 #24097
Conversation
msft-fluent-ui-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).
Please do one of the following:
- If you've already created a PR to
master, add a link to it - If the change is irrelevant to version 8, add a comment explaining why
- Otherwise, create a PR to
masterwith this same change, and add a link to it
After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).
Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).
These export no longer exist in master branch and are 7.0 only
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bdeb1a4:
|
change/office-ui-fabric-react-3cf6a1f4-b206-49b1-87d1-91879e08f9c0.json
Outdated
Show resolved
Hide resolved
change/office-ui-fabric-react-56d8b231-12d4-4bca-8131-9da8a848954b.json
Outdated
Show resolved
Hide resolved
|
Seems like you need to update the API files. |
…954b.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
…f9c0.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
…oxMSFT/fluentui into add-decorators-to-exports
Asset size changes
Baseline commit: d905d75d002f5fe9a24774a7e19b8842d1162b75 (build) |
Perf AnalysisNo significant results to display. All results
|
Issue
v7 office-ui-fabric-react allows deep imports of withResponsiveMode and withViewport, but v7 @fluentui/react does not.
ODSP needs these exported in order to move to the modern import name.
Changes
-- exported withResponsiveMode and withViewport methods and types from @fluentui/react/Decorators