Skip to content

Conversation

@smhigley
Copy link
Contributor

Cherry pick to v7 of #24212

Adds popupProps to Callout in v7

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 22, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 399bb82:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Nov 22, 2022

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-HoverCard 98.336 kB 98.353 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-MessageBar 187.391 kB 187.408 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-ComboBox 243.753 kB 243.77 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-SelectedItemsList 228.768 kB 228.785 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-CommandBar 199.152 kB 199.169 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-SearchBox 185.203 kB 185.22 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-ContextualMenu 155.539 kB 155.556 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-DatePicker 208.548 kB 208.565 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Nav 185.423 kB 185.44 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Panel 198.786 kB 198.803 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Dialog 209.076 kB 209.093 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-DocumentCard 213.435 kB 213.452 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Pivot 183.899 kB 183.916 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Pickers 285.312 kB 285.329 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Dropdown 230.603 kB 230.62 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-PersonaCoin 114.172 kB 114.189 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Facepile 208.15 kB 208.167 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-FloatingPicker 238.66 kB 238.677 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Persona 114.172 kB 114.189 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Breadcrumb 197.572 kB 197.589 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-SpinButton 191.219 kB 191.236 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Keytips 103.878 kB 103.895 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-KeytipLayer 100.707 kB 100.724 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Callout 85.7 kB 85.717 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-SwatchColorPicker 188.941 kB 188.958 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-TeachingBubble 203.955 kB 203.972 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Tooltip 85.308 kB 85.325 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Grid 178.581 kB 178.598 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-ButtonGrid 178.581 kB 178.598 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Keytip 80.044 kB 80.061 kB ExceedsBaseline     17 bytes
office-ui-fabric-react office-ui-fabric-react-Button 192.236 kB 192.253 kB ExceedsBaseline     17 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 3b8aa5382bdeee0472719bc3f5a27827c170fb44 (build)

Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 765 782 5000
Breadcrumb mount 35397 35217 5000
Checkbox mount 1293 1285 5000
CheckboxBase mount 1092 1087 5000
ChoiceGroup mount 4057 4048 5000
ComboBox mount 690 699 1000
CommandBar mount 6593 6587 1000
ContextualMenu mount 11809 11883 1000
DefaultButton mount 946 951 5000
DetailsRow mount 2992 2955 5000
DetailsRowFast mount 2973 3008 5000
DetailsRowNoStyles mount 2840 2822 5000
Dialog mount 1797 1763 1000
DocumentCardTitle mount 1537 1532 1000
Dropdown mount 2049 2025 5000
FocusTrapZone mount 1435 1399 5000
FocusZone mount 1481 1528 5000
IconButton mount 1390 1397 5000
Label mount 321 318 5000
Layer mount 1629 1639 5000
Link mount 402 401 5000
MenuButton mount 1187 1211 5000
MessageBar mount 1812 1822 5000
Nav mount 2613 2632 1000
OverflowSet mount 1194 1214 5000
Panel mount 1212 1202 1000
Persona mount 795 803 1000
Pivot mount 1125 1126 1000
PrimaryButton mount 1053 1072 5000
Rating mount 6714 6691 5000
SearchBox mount 1054 1060 5000
Shimmer mount 2279 2261 5000
Slider mount 1270 1317 5000
SpinButton mount 3925 3892 5000
Spinner mount 386 386 5000
SplitButton mount 2454 2459 5000
Stack mount 464 459 5000
StackWithIntrinsicChildren mount 1401 1406 5000
StackWithTextChildren mount 4316 4296 5000
SwatchColorPicker mount 8166 8163 5000
TagPicker mount 2119 2186 5000
TeachingBubble mount 41687 41770 5000
Text mount 401 407 5000
TextField mount 1161 1162 5000
Toggle mount 733 754 5000
button mount 88 92 5000

@smhigley smhigley merged commit 0a1ed8f into microsoft:7.0 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants