Skip to content

Panel non modal#265

Merged
Jahnp merged 8 commits intomicrosoft:masterfrom
mattlind:panelNonModal
Nov 4, 2016
Merged

Panel non modal#265
Jahnp merged 8 commits intomicrosoft:masterfrom
mattlind:panelNonModal

Conversation

@mattlind
Copy link
Copy Markdown
Collaborator

@mattlind mattlind commented Sep 8, 2016

Added isModal switch for the Panel control. Turns off the usage of the Overlay control (which effectively also disables lightDismiss).

Not sure if a the team wants a non-modal dialog example but I added that as well.

@msftclas
Copy link
Copy Markdown

msftclas commented Sep 8, 2016

Hi @mattlind, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link
Copy Markdown

@mattlind, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@Jahnp
Copy link
Copy Markdown
Member

Jahnp commented Nov 3, 2016

Approved

Sorry for the delay here. This change makes sense to me. Once you've addressed the conflicts, happy to merge this in.

@mattlind
Copy link
Copy Markdown
Collaborator Author

mattlind commented Nov 3, 2016

Thanks, almost gave up on this one. I will get it up to date.

On Thu, Nov 3, 2016, 4:08 PM Peter Jahn notifications@github.com wrote:

Approved

Sorry for the delay here. This change makes sense to me. Once you've
addressed the conflicts, happy to merge this in.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#265 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJJ6BJIOtVExecYa1p23qnJF7bppul0uks5q6mlfgaJpZM4J4U9G
.

@Jahnp
Copy link
Copy Markdown
Member

Jahnp commented Nov 4, 2016

Awesome, thanks for fixing the conflicts! I'll go ahead and merge once CI has finished.

@Jahnp Jahnp merged commit 1cfe419 into microsoft:master Nov 4, 2016
@mattlind mattlind deleted the panelNonModal branch November 4, 2016 20:40
@mattlind mattlind restored the panelNonModal branch November 8, 2016 19:47
@mattlind mattlind deleted the panelNonModal branch November 8, 2016 21:28
gokunymbus pushed a commit to gokunymbus/office-ui-fabric-react that referenced this pull request Jan 24, 2017
@LarsLiden
Copy link
Copy Markdown
Member

LarsLiden commented Nov 7, 2017

I just filed #3333. Buttons outside the non-modal panel respond to hover events but not button clicks. Without this, I'm not really sure what the purpose of a non-modal panel is. @mattlind

@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants