feat(scripts-monorepo): migrate to lerna 7 apis #29281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 48f7e6f:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 86dd76990e3da5af1f2b6b04a3aec46141d5a653 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 651 | 643 | 5000 | |
| Button | mount | 327 | 331 | 5000 | |
| Field | mount | 1114 | 1499 | 5000 | |
| FluentProvider | mount | 709 | 706 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 67 | 65 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 71 | 70 | 10 | |
| InfoButton | mount | 19 | 11 | 5000 | |
| MakeStyles | mount | 921 | 966 | 50000 | |
| Persona | mount | 1750 | 1978 | 5000 | |
| SpinButton | mount | 1388 | 1385 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentSlotsPerf.default | 648 | 597 | 1.09:1 |
| FlexMinimalPerf.default | 160 | 147 | 1.09:1 |
| ImageMinimalPerf.default | 221 | 205 | 1.08:1 |
| ButtonSlotsPerf.default | 328 | 306 | 1.07:1 |
| DividerMinimalPerf.default | 209 | 196 | 1.07:1 |
| ChatDuplicateMessagesPerf.default | 153 | 145 | 1.06:1 |
| ChatWithPopoverPerf.default | 198 | 186 | 1.06:1 |
| DropdownManyItemsPerf.default | 395 | 377 | 1.05:1 |
| LabelMinimalPerf.default | 226 | 216 | 1.05:1 |
| RefMinimalPerf.default | 108 | 103 | 1.05:1 |
| TooltipMinimalPerf.default | 1302 | 1244 | 1.05:1 |
| AvatarMinimalPerf.default | 104 | 100 | 1.04:1 |
| BoxMinimalPerf.default | 198 | 190 | 1.04:1 |
| HeaderMinimalPerf.default | 203 | 196 | 1.04:1 |
| ItemLayoutMinimalPerf.default | 702 | 674 | 1.04:1 |
| AlertMinimalPerf.default | 152 | 147 | 1.03:1 |
| TableMinimalPerf.default | 233 | 227 | 1.03:1 |
| EmbedMinimalPerf.default | 1871 | 1836 | 1.02:1 |
| ListNestedPerf.default | 322 | 315 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2275 | 2223 | 1.02:1 |
| TextMinimalPerf.default | 193 | 190 | 1.02:1 |
| ListCommonPerf.default | 371 | 368 | 1.01:1 |
| ProviderMinimalPerf.default | 204 | 201 | 1.01:1 |
| SegmentMinimalPerf.default | 195 | 193 | 1.01:1 |
| SkeletonMinimalPerf.default | 195 | 193 | 1.01:1 |
| AttachmentMinimalPerf.default | 78 | 78 | 1:1 |
| ButtonMinimalPerf.default | 81 | 81 | 1:1 |
| CardMinimalPerf.default | 306 | 306 | 1:1 |
| DatepickerMinimalPerf.default | 3515 | 3513 | 1:1 |
| DropdownMinimalPerf.default | 1415 | 1417 | 1:1 |
| MenuButtonMinimalPerf.default | 952 | 949 | 1:1 |
| RadioGroupMinimalPerf.default | 263 | 262 | 1:1 |
| StatusMinimalPerf.default | 388 | 387 | 1:1 |
| TextAreaMinimalPerf.default | 282 | 282 | 1:1 |
| CarouselMinimalPerf.default | 251 | 254 | 0.99:1 |
| ChatMinimalPerf.default | 423 | 428 | 0.99:1 |
| DialogMinimalPerf.default | 434 | 439 | 0.99:1 |
| ListMinimalPerf.default | 302 | 306 | 0.99:1 |
| MenuMinimalPerf.default | 488 | 495 | 0.99:1 |
| PopupMinimalPerf.default | 339 | 342 | 0.99:1 |
| TableManyItemsPerf.default | 1116 | 1124 | 0.99:1 |
| AnimationMinimalPerf.default | 293 | 298 | 0.98:1 |
| ButtonOverridesMissPerf.default | 638 | 649 | 0.98:1 |
| CheckboxMinimalPerf.default | 1100 | 1124 | 0.98:1 |
| RosterPerf.default | 1522 | 1549 | 0.98:1 |
| SliderMinimalPerf.default | 725 | 739 | 0.98:1 |
| IconMinimalPerf.default | 380 | 389 | 0.98:1 |
| ToolbarMinimalPerf.default | 521 | 530 | 0.98:1 |
| TreeMinimalPerf.default | 453 | 464 | 0.98:1 |
| GridMinimalPerf.default | 183 | 189 | 0.97:1 |
| ListWith60ListItems.default | 359 | 370 | 0.97:1 |
| LoaderMinimalPerf.default | 194 | 200 | 0.97:1 |
| CustomToolbarPrototype.default | 1469 | 1510 | 0.97:1 |
| HeaderSlotsPerf.default | 447 | 466 | 0.96:1 |
| InputMinimalPerf.default | 512 | 535 | 0.96:1 |
| LayoutMinimalPerf.default | 192 | 201 | 0.96:1 |
| PortalMinimalPerf.default | 80 | 83 | 0.96:1 |
| ProviderMergeThemesPerf.default | 636 | 668 | 0.95:1 |
| VideoMinimalPerf.default | 439 | 460 | 0.95:1 |
| FormMinimalPerf.default | 207 | 221 | 0.94:1 |
| AccordionMinimalPerf.default | 76 | 82 | 0.93:1 |
| ReactionMinimalPerf.default | 199 | 218 | 0.91:1 |
| TreeWith60ListItems.default | 80 | 98 | 0.82:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 625 | 633 | 5000 | |
| Breadcrumb | mount | 1740 | 1668 | 1000 | |
| Checkbox | mount | 1686 | 1693 | 5000 | |
| CheckboxBase | mount | 1487 | 1466 | 5000 | |
| ChoiceGroup | mount | 2926 | 2933 | 5000 | |
| ComboBox | mount | 650 | 659 | 1000 | |
| CommandBar | mount | 6247 | 6268 | 1000 | |
| ContextualMenu | mount | 14845 | 14941 | 1000 | |
| DefaultButton | mount | 751 | 741 | 5000 | |
| DetailsRow | mount | 2218 | 2164 | 5000 | |
| DetailsRowFast | mount | 2204 | 2181 | 5000 | |
| DetailsRowNoStyles | mount | 2012 | 2024 | 5000 | |
| Dialog | mount | 2631 | 2615 | 1000 | |
| DocumentCardTitle | mount | 231 | 232 | 1000 | |
| Dropdown | mount | 2017 | 1959 | 5000 | |
| FocusTrapZone | mount | 1102 | 1129 | 5000 | |
| FocusZone | mount | 1057 | 1070 | 5000 | |
| GroupedList | mount | 41185 | 41954 | 2 | |
| GroupedList | virtual-rerender | 19802 | 19547 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50204 | 50510 | 2 | |
| GroupedListV2 | mount | 221 | 223 | 2 | |
| GroupedListV2 | virtual-rerender | 218 | 210 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 220 | 237 | 2 | |
| IconButton | mount | 1077 | 1061 | 5000 | |
| Label | mount | 333 | 332 | 5000 | |
| Layer | mount | 2755 | 2733 | 5000 | |
| Link | mount | 398 | 394 | 5000 | |
| MenuButton | mount | 970 | 960 | 5000 | |
| MessageBar | mount | 21121 | 21298 | 5000 | |
| Nav | mount | 1952 | 1887 | 1000 | |
| OverflowSet | mount | 764 | 775 | 5000 | |
| Panel | mount | 1778 | 1755 | 1000 | |
| Persona | mount | 713 | 734 | 1000 | |
| Pivot | mount | 850 | 878 | 1000 | |
| PrimaryButton | mount | 843 | 824 | 5000 | |
| Rating | mount | 4497 | 4588 | 5000 | |
| SearchBox | mount | 914 | 900 | 5000 | |
| Shimmer | mount | 1798 | 1884 | 5000 | |
| Slider | mount | 1338 | 1329 | 5000 | |
| SpinButton | mount | 2820 | 2848 | 5000 | |
| Spinner | mount | 383 | 376 | 5000 | |
| SplitButton | mount | 1798 | 1803 | 5000 | |
| Stack | mount | 393 | 402 | 5000 | |
| StackWithIntrinsicChildren | mount | 839 | 852 | 5000 | |
| StackWithTextChildren | mount | 2569 | 2564 | 5000 | |
| SwatchColorPicker | mount | 6039 | 6154 | 5000 | |
| TagPicker | mount | 1435 | 1452 | 5000 | |
| Text | mount | 352 | 369 | 5000 | |
| TextField | mount | 915 | 943 | 5000 | |
| ThemeProvider | mount | 834 | 824 | 5000 | |
| ThemeProvider | virtual-rerender | 586 | 585 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1247 | 1262 | 5000 | |
| Toggle | mount | 606 | 594 | 5000 | |
| buttonNative | mount | 193 | 193 | 5000 |
Hotell
force-pushed
the
hotell/nx/lerna-7-migration-v2
branch
2 times, most recently
from
5d6f271 to
62bc126
Compare
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
commented
Sep 26, 2023
Hotell
commented
Sep 26, 2023
Hotell
force-pushed
the
hotell/nx/lerna-7-migration-v2
branch
2 times, most recently
from
e065e3e to
1c0f21c
Compare
Hotell
commented
Sep 29, 2023
Hotell
force-pushed
the
hotell/nx/lerna-7-migration-v2
branch
2 times, most recently
from
d11c689 to
5ed899b
Compare
github-actions
bot
modified the milestones:
September Project Cycle Q4 2023,
October Project Cycle Q4 2023
Hotell
force-pushed
the
hotell/nx/lerna-7-migration-v2
branch
from
5ed899b to
7a37bcd
Compare
…ithin packPackages to migrate to lerna v7 apis
…t. will fail otherwise
…ts file for getDependencies to make it work in both js/ts modules
… old lerna/yarn workspaces would to avoid circular dependencies
…cies function to return map array including tests
…ackProjectPackages func
…om result array to make the cleanup API
…invoked only for single project
Hotell
force-pushed
the
hotell/nx/lerna-7-migration-v2
branch
from
959be6c to
2d26928
Compare
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Hotell
commented
Oct 4, 2023
Hotell
commented
Oct 4, 2023
tudorpopams
approved these changes
Oct 5, 2023
ling1726
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
see referenced issue
New Behavior
getDependenciesnow uses lerna v7 apis ( driven by nx under the hood )getDependenciesis used within@fluentui/scripts-projects-testto reduce duplicationgetDependencies.d.tslerna/utilstypes have been added to/typingsprojectgetDependenciesandpackProjectPackagesapisRelated Issue(s)