-
Notifications
You must be signed in to change notification settings - Fork 2.9k
(Performance testing): on tokens.ts (not actual architecture) #31672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
EdDaWord
wants to merge
10
commits into
microsoft:master
Choose a base branch
from
brandonthomas:var-fallback-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricteam
reviewed
Jun 11, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Accordion 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Accordion.Size - Dark Mode.normal.chromium.png | 2 | Changed |
| Accordion.Size.normal.chromium.png | 2 | Changed |
| Accordion.Size - RTL.normal.chromium.png | 2 | Changed |
Avatar 8 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar.Colorful - Dark Mode.normal.chromium.png | 452 | Changed |
| Avatar.Color - RTL.normal.chromium.png | 1 | Changed |
| Avatar.Colorful - RTL.normal.chromium.png | 326 | Changed |
| Avatar.Active Appearance - Dark Mode.normal.chromium.png | 2 | Changed |
| Avatar.Colorful.normal.chromium.png | 325 | Changed |
| Avatar.Color.normal.chromium.png | 1 | Changed |
| Avatar.Active Appearance.normal.chromium.png | 10 | Changed |
| Avatar.Active.normal.chromium.png | 5 | Changed |
Badge 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Badge.Color.normal.chromium.png | 1 | Changed |
| Badge.Appearance.normal.chromium.png | 1 | Changed |
| Badge.Default.normal.chromium.png | 1 | Changed |
| Badge.Appearance - Dark Mode.normal.chromium.png | 15 | Changed |
| Badge.Shape.normal.chromium.png | 1 | Changed |
| Badge.Size.normal.chromium.png | 6 | Changed |
Button 75 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Button.Large Icon Only - Dark Mode.hover.chromium.png | 3 | Changed |
| Button.Large Icon Only.default.chromium.png | 5 | Changed |
| Button.Large Icon Only - Dark Mode.pressed.chromium.png | 5 | Changed |
| Button.Large With Icon - Dark Mode.pressed.chromium.png | 822 | Changed |
| Button.Large With Icon - Dark Mode.hover.chromium.png | 731 | Changed |
| Button.Large With Icon - Dark Mode.default.chromium.png | 782 | Changed |
| Button.Large Icon Only.pressed.chromium.png | 3 | Changed |
| Button.Medium With Icon - Dark Mode.pressed.chromium.png | 813 | Changed |
| Button.Large With Icon - RTL.hover.chromium.png | 761 | Changed |
| Button.Medium With Icon - Dark Mode.hover.chromium.png | 720 | Changed |
| Button.Medium With Icon - RTL.pressed.chromium.png | 697 | Changed |
| Button.Large With Icon.pressed.chromium.png | 707 | Changed |
| Button.Medium With Icon - Dark Mode.default.chromium.png | 775 | Changed |
| Button.Medium With Icon.hover.chromium.png | 753 | Changed |
| Button.Large With Icon.default.chromium.png | 795 | Changed |
| Button.Large With Icon - RTL.pressed.chromium.png | 707 | Changed |
| Button.Outline Disabled - Dark Mode.hover.chromium.png | 159 | Changed |
| Button.Large With Icon.hover.chromium.png | 761 | Changed |
| Button.Medium With Icon - RTL.default.chromium.png | 788 | Changed |
| Button.Medium With Icon.default.chromium.png | 788 | Changed |
| Button.Outline Disabled Focusable - Dark Mode.pressed.chromium.png | 159 | Changed |
| Button.Outline Disabled Focusable - Dark Mode.default.chromium.png | 159 | Changed |
| Button.Large With Icon - RTL.default.chromium.png | 795 | Changed |
| Button.Outline Disabled - Dark Mode.pressed.chromium.png | 159 | Changed |
| Button.Primary Disabled Focusable - Dark Mode.default.chromium.png | 44 | Changed |
| Button.Medium With Icon.pressed.chromium.png | 697 | Changed |
| Button.Primary Disabled Focusable - Dark Mode.pressed.chromium.png | 44 | Changed |
| Button.Primary Disabled - Dark Mode.hover.chromium.png | 44 | Changed |
| Button.Primary Disabled Focusable.hover.chromium.png | 15 | Changed |
| Button.Primary Disabled.default.chromium.png | 15 | Changed |
| Button.Large Icon Only.hover.chromium.png | 4 | Changed |
| Button.Primary Disabled.hover.chromium.png | 15 | Changed |
| Button.Primary Disabled - Dark Mode.pressed.chromium.png | 44 | Changed |
| Button.Primary Disabled - Dark Mode.default.chromium.png | 44 | Changed |
| Button.Primary Disabled Focusable.pressed.chromium.png | 15 | Changed |
| Button.Primary Disabled.pressed.chromium.png | 15 | Changed |
| Button.Small With Icon - Dark Mode.default.chromium.png | 334 | Changed |
| Button.Outline Disabled - Dark Mode.default.chromium.png | 159 | Changed |
| Button.Small With Icon - Dark Mode.pressed.chromium.png | 351 | Changed |
| Button.Small With Icon - Dark Mode.hover.chromium.png | 311 | Changed |
| Button.Small With Icon.default.chromium.png | 339 | Changed |
| Button.Small With Icon - RTL.hover.chromium.png | 324 | Changed |
| Button.Primary Disabled Focusable.default.chromium.png | 15 | Changed |
| Button.Medium With Icon - RTL.hover.chromium.png | 753 | Changed |
| Button.Small With Icon - RTL.pressed.chromium.png | 301 | Changed |
| Button.Primary Disabled Focusable - Dark Mode.hover.chromium.png | 44 | Changed |
| Button.Small With Icon - RTL.default.chromium.png | 339 | Changed |
| Button.Subtle Disabled - Dark Mode.pressed.chromium.png | 187 | Changed |
| Button.Subtle Disabled Focusable - Dark Mode.default.chromium.png | 187 | Changed |
| Button.Subtle Disabled - Dark Mode.default.chromium.png | 187 | Changed |
| Button.Subtle Disabled Focusable.default.chromium.png | 25 | Changed |
| Button.Subtle Disabled Focusable.hover.chromium.png | 25 | Changed |
| Button.Subtle Disabled.pressed.chromium.png | 25 | Changed |
| Button.Subtle Disabled.hover.chromium.png | 25 | Changed |
| Button.Large Icon Only - Dark Mode.default.chromium.png | 4 | Changed |
| Button.Outline Disabled Focusable - Dark Mode.hover.chromium.png | 159 | Changed |
| Button.Small With Icon.hover.chromium.png | 324 | Changed |
| Button.Small With Icon.pressed.chromium.png | 301 | Changed |
| Button.Transparent Disabled - Dark Mode.hover.chromium.png | 199 | Changed |
| Button.Transparent Disabled.default.chromium.png | 27 | Changed |
| Button.Transparent Disabled Focusable - Dark Mode.hover.chromium.png | 199 | Changed |
| Button.Subtle Disabled - Dark Mode.hover.chromium.png | 187 | Changed |
| Button.Transparent Disabled - Dark Mode.default.chromium.png | 199 | Changed |
| Button.Subtle Disabled Focusable.pressed.chromium.png | 25 | Changed |
| Button.Transparent Disabled Focusable.pressed.chromium.png | 27 | Changed |
| Button.Transparent Disabled.hover.chromium.png | 27 | Changed |
| Button.Subtle Disabled Focusable - Dark Mode.hover.chromium.png | 187 | Changed |
| Button.Transparent Disabled Focusable - Dark Mode.default.chromium.png | 199 | Changed |
| Button.Transparent Disabled Focusable - Dark Mode.pressed.chromium.png | 199 | Changed |
| Button.Transparent Disabled.pressed.chromium.png | 27 | Changed |
| Button.Subtle Disabled.default.chromium.png | 25 | Changed |
| Button.Subtle Disabled Focusable - Dark Mode.pressed.chromium.png | 187 | Changed |
| Button.Transparent Disabled Focusable.default.chromium.png | 27 | Changed |
| Button.Transparent Disabled - Dark Mode.pressed.chromium.png | 199 | Changed |
| Button.Transparent Disabled Focusable.hover.chromium.png | 27 | Changed |
Checkbox 26 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Checkbox.Checked.normal.chromium.png | 4855 | Changed |
| Checkbox.Circular - RTL.normal.chromium.png | 4733 | Changed |
| Checkbox.Circular Checked.normal.chromium.png | 4883 | Changed |
| Checkbox.Circular Indeterminate - Dark Mode.indeterminate.chromium.png | 1102 | Changed |
| Checkbox.Circular Disabled Checked.normal.chromium.png | 4728 | Changed |
| Checkbox.Circular Indeterminate.normal.chromium.png | 4786 | Changed |
| Checkbox.Circular Disabled Checked - Dark Mode.normal.chromium.png | 799 | Changed |
| Checkbox.Circular Checked - Dark Mode.normal.chromium.png | 1080 | Changed |
| Checkbox.Default - RTL.normal.chromium.png | 4751 | Changed |
| Checkbox.Disabled Checked - Dark Mode.normal.chromium.png | 777 | Changed |
| Checkbox.Disabled.normal.chromium.png | 4705 | Changed |
| Checkbox.Indeterminate - Dark Mode.normal.chromium.png | 877 | Changed |
| Checkbox.Disabled - Dark Mode.normal.chromium.png | 739 | Changed |
| Checkbox.Indeterminate - Dark Mode.indeterminate.chromium.png | 993 | Changed |
| Checkbox.Circular Indeterminate - Dark Mode.normal.chromium.png | 936 | Changed |
| Checkbox.Disabled Checked.normal.chromium.png | 4721 | Changed |
| Checkbox.Circular - Dark Mode.normal.chromium.png | 792 | Changed |
| Checkbox.Circular Indeterminate.indeterminate.chromium.png | 4869 | Changed |
| Checkbox.Indeterminate.normal.chromium.png | 4776 | Changed |
| Checkbox.Checked - Dark Mode.normal.chromium.png | 982 | Changed |
| Checkbox.Default.normal.chromium.png | 4751 | Changed |
| Checkbox.Indeterminate.indeterminate.chromium.png | 4847 | Changed |
| Checkbox.Circular Disabled.normal.chromium.png | 4711 | Changed |
| Checkbox.Circular Disabled - Dark Mode.normal.chromium.png | 760 | Changed |
| Checkbox.Circular.normal.chromium.png | 4734 | Changed |
| Checkbox.Default - Dark Mode.normal.chromium.png | 814 | Changed |
Divider 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Divider.With Svg - RTL.normal.chromium.png | 3 | Changed |
| Divider.With Svg.normal.chromium.png | 3 | Changed |
| Divider.Vertical With Svg.normal.chromium.png | 4 | Changed |
Label 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Label.Required - RTL.normal.chromium.png | 11 | Changed |
| Label.Size Small.normal.chromium.png | 661 | Changed |
Link 10 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Link.Default.default.chromium.png | 0 | Added |
| Link.Default.hover.chromium.png | 0 | Added |
| Link.Default.pressed.chromium.png | 0 | Added |
| Link.Inline.default.chromium.png | 0 | Added |
| Link.Inline.hover.chromium.png | 0 | Added |
| Link.Inline.pressed.chromium.png | 0 | Added |
| Link.Subtle.default.chromium.png | 0 | Added |
| Link.Subtle.hover.chromium.png | 0 | Added |
| Link.Subtle.pressed.chromium.png | 0 | Added |
| Link.With Long Text.default.chromium.png | 0 | Added |
MenuList 16 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| MenuList.Checkbox - RTL.2nd selected.chromium.png | 1 | Changed |
| MenuList.Checkbox With Icons - RTL.1st selected.chromium.png | 4 | Changed |
| MenuList.Checkbox.2nd selected.chromium.png | 1 | Changed |
| MenuList.Radio With Icons - RTL.2nd selected.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons.2nd selected.chromium.png | 5 | Changed |
| MenuList.Checkbox With Icons - RTL.normal.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons - RTL.2nd selected.chromium.png | 5 | Changed |
| MenuList.Radio With Icons.2nd selected.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.normal.chromium.png | 4 | Changed |
| MenuList.With Icons.hover menuitem.chromium.png | 3 | Changed |
| MenuList.Radio With Icons.1st selected.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons.1st selected.chromium.png | 4 | Changed |
| MenuList.With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.1st selected.chromium.png | 4 | Changed |
Slider 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Slider.Size Small.rightArrow.chromium.png | 1 | Changed |
| Slider.Size Small.normal.chromium.png | 1 | Changed |
Switch 34 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Switch.Default - RTL.hover.chromium.png | 5044 | Changed |
| Switch.Checked.hover.chromium.png | 5150 | Changed |
| Switch.Checked.normal.chromium.png | 5132 | Changed |
| Switch.Disabled - Dark Mode.normal.chromium.png | 909 | Changed |
| Switch.Checked - RTL.hover.chromium.png | 5150 | Changed |
| Switch.Disabled - Dark Mode.hover.chromium.png | 909 | Changed |
| Switch.Disabled - RTL.normal.chromium.png | 4914 | Changed |
| Switch.Default - Dark Mode.hover.chromium.png | 1071 | Changed |
| Switch.Checked - Dark Mode.hover.chromium.png | 1169 | Changed |
| Switch.Disabled - RTL.hover.chromium.png | 4914 | Changed |
| Switch.Disabled Checked - Dark Mode.normal.chromium.png | 1074 | Changed |
| Switch.Disabled.hover.chromium.png | 4914 | Changed |
| Switch.Checked - RTL.normal.chromium.png | 5132 | Changed |
| Switch.Checked - Dark Mode.normal.chromium.png | 1130 | Changed |
| Switch.Default.hover.chromium.png | 5044 | Changed |
| Switch.Default - RTL.normal.chromium.png | 5009 | Changed |
| Switch.Disabled Checked.normal.chromium.png | 5047 | Changed |
| Switch.Disabled Checked - Dark Mode.hover.chromium.png | 1074 | Changed |
| Switch.Default.normal.chromium.png | 5009 | Changed |
| Switch.Disabled.normal.chromium.png | 4914 | Changed |
| Switch.Default - Dark Mode.normal.chromium.png | 1019 | Changed |
| Switch.Disabled Checked.hover.chromium.png | 5047 | Changed |
| Switch.Label Above - RTL.hover.chromium.png | 0 | Removed |
| Switch.Label Above - RTL.normal.chromium.png | 0 | Removed |
| Switch.Label Above.hover.chromium.png | 0 | Removed |
| Switch.Label Above.normal.chromium.png | 0 | Removed |
| Switch.Label After - RTL.hover.chromium.png | 0 | Removed |
| Switch.Label After - RTL.normal.chromium.png | 0 | Removed |
| Switch.Label After.hover.chromium.png | 0 | Removed |
| Switch.Label After.normal.chromium.png | 0 | Removed |
| Switch.Label Before - RTL.hover.chromium.png | 0 | Removed |
| Switch.Label Before - RTL.normal.chromium.png | 0 | Removed |
| Switch.Label Before.hover.chromium.png | 0 | Removed |
| Switch.Label Before.normal.chromium.png | 0 | Removed |
Text 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Text.Strikethrough.normal.chromium.png | 236 | Changed |
| Text.Block.normal.chromium.png | 995 | Changed |
TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| TextInput.Size Large.normal.chromium.png | 3 | Changed |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 42 | 34 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 643 | 643 | 5000 | |
| Button | mount | 309 | 302 | 5000 | |
| Field | mount | 1128 | 1139 | 5000 | |
| FluentProvider | mount | 717 | 717 | 5000 | |
| FluentProviderWithTheme | mount | 91 | 83 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 42 | 34 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 74 | 10 | |
| MakeStyles | mount | 867 | 881 | 50000 | |
| Persona | mount | 1748 | 1722 | 5000 | |
| SpinButton | mount | 1404 | 1452 | 5000 | |
| SwatchPicker | mount | 1622 | 1641 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
fabricteam
reviewed
Jun 11, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the affected screenshots
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask - RTL.normal.chromium.png | 3 | Changed |
| Avatar Converged.customSize+image.normal.chromium.png | 0 | Added |
Card Converged - Interactive 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Card Converged - Interactive.appearance interactive - Filled - High Contrast.click.chromium.png | 0 | Added |
| Card Converged - Interactive.appearance interactive - Filled - High Contrast.hover.chromium.png | 0 | Added |
| Card Converged - Interactive.appearance interactive - Filled - High Contrast.normal.chromium.png | 0 | Added |
Image Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Image Converged.Image Variations Fallback.normal.chromium.png | 0 | Added |
SwatchPicker Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| SwatchPicker Converged.spacing.default.chromium.png | 0 | Added |
df60a32 to
d8c6e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Purpose
For performance testing to show that there is no degradation.
Adding multiple unique fallbacks to the tokens file.

Related Prototype PRs:
#31330