Skip to content

chore: rework context selector#32226

Closed
layershifter wants to merge 2 commits intomicrosoft:masterfrom
layershifter:chore/tearing-selector
Closed

chore: rework context selector#32226
layershifter wants to merge 2 commits intomicrosoft:masterfrom
layershifter:chore/tearing-selector

Conversation

@layershifter
Copy link
Copy Markdown
Member

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@github-actions github-actions Bot added this to the August Project Cycle Q3 2024 milestone Aug 5, 2024
@fabricteam
Copy link
Copy Markdown
Collaborator

fabricteam commented Aug 5, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
104.333 kB
32.092 kB
99.749 kB
30.469 kB
-4.584 kB
-1.623 kB
react-avatar
AvatarGroup
20.107 kB
7.973 kB
15.584 kB
6.36 kB
-4.523 kB
-1.613 kB
react-avatar
AvatarGroupItem
63.445 kB
20.061 kB
58.666 kB
18.333 kB
-4.779 kB
-1.728 kB
react-combobox
Combobox (including child components)
103.763 kB
34.054 kB
99.163 kB
32.481 kB
-4.6 kB
-1.573 kB
react-combobox
Dropdown (including child components)
104.349 kB
33.963 kB
99.749 kB
32.403 kB
-4.6 kB
-1.56 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
217.412 kB
63.063 kB
212.816 kB
61.393 kB
-4.596 kB
-1.67 kB
react-components
react-components: entire library
1.095 MB
270.359 kB
1.09 MB
268.598 kB
-4.59 kB
-1.761 kB
react-dialog
Dialog (including children components)
99.413 kB
29.881 kB
94.812 kB
28.239 kB
-4.601 kB
-1.642 kB
react-menu
Menu (including children components)
151.286 kB
45.713 kB
146.693 kB
44.049 kB
-4.593 kB
-1.664 kB
react-menu
Menu (including selectable components)
153.972 kB
46.205 kB
149.379 kB
44.542 kB
-4.593 kB
-1.663 kB
react-overflow
hooks only
12.821 kB
4.813 kB
8.095 kB
3.067 kB
-4.726 kB
-1.746 kB
react-popover
Popover
127.757 kB
39.988 kB
123.174 kB
38.313 kB
-4.583 kB
-1.675 kB
react-swatch-picker
@fluentui/react-swatch-picker - package
103.73 kB
30.098 kB
99.147 kB
28.458 kB
-4.583 kB
-1.64 kB
react-table
DataGrid
160.337 kB
45.661 kB
155.747 kB
44.055 kB
-4.59 kB
-1.606 kB
react-tag-picker
@fluentui/react-tag-picker - package
181.367 kB
54.538 kB
176.774 kB
52.952 kB
-4.593 kB
-1.586 kB
react-timepicker-compat
TimePicker
106.751 kB
35.596 kB
102.151 kB
34.01 kB
-4.6 kB
-1.586 kB
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
328 B
global-context
createContextSelector
537 B
339 B
react-avatar
Avatar
49.301 kB
15.838 kB
react-breadcrumb
@fluentui/react-breadcrumb - package
113.697 kB
31.537 kB
react-checkbox
Checkbox
35.105 kB
12.112 kB
react-components
react-components: Button, FluentProvider & webLightTheme
69.141 kB
20.157 kB
react-components
react-components: FluentProvider & webLightTheme
44.442 kB
14.607 kB
react-datepicker-compat
DatePicker Compat
223.049 kB
63.147 kB
react-field
Field
23.384 kB
8.903 kB
react-input
Input
28.015 kB
9.456 kB
react-motion
@fluentui/react-motion - createMotionComponent()
4.108 kB
1.844 kB
react-motion
@fluentui/react-motion - createPresenceComponent()
4.869 kB
2.169 kB
react-motion
@fluentui/react-motion - PresenceGroup
1.714 kB
819 B
react-persona
Persona
56.192 kB
17.728 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-progress
ProgressBar
17.086 kB
6.906 kB
react-radio
Radio
32.673 kB
10.351 kB
react-radio
RadioGroup
15.76 kB
6.433 kB
react-select
Select
27.723 kB
10.131 kB
react-slider
Slider
37.17 kB
12.547 kB
react-spinbutton
SpinButton
36.102 kB
11.85 kB
react-switch
Switch
35.301 kB
11.348 kB
react-table
Table (Primitives only)
42.482 kB
13.868 kB
react-table
Table as DataGrid
131.142 kB
36.351 kB
react-table
Table (Selection only)
70.336 kB
20.028 kB
react-table
Table (Sort only)
68.979 kB
19.633 kB
react-tags
InteractionTag
15.167 kB
6.135 kB
react-tags
Tag
28.996 kB
9.52 kB
react-tags
TagGroup
82.124 kB
24.344 kB
react-textarea
Textarea
26.572 kB
9.769 kB
react-toast
Toast (including Toaster)
97.634 kB
29.387 kB
🤖 This report was generated against b6b53b9f4b56968cdf6e127692b5abfd807e0f46

@fabricteam
Copy link
Copy Markdown
Collaborator

fabricteam commented Aug 5, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 635 615 5000
Button mount 294 304 5000
Field mount 1130 1171 5000
FluentProvider mount 702 738 5000
FluentProviderWithTheme mount 77 89 10
FluentProviderWithTheme virtual-rerender 32 34 10
FluentProviderWithTheme virtual-rerender-with-unmount 77 76 10
MakeStyles mount 858 861 50000
Persona mount 1760 1754 5000
SpinButton mount 1403 1444 5000
SwatchPicker mount 1643 1655 5000

@layershifter layershifter force-pushed the chore/tearing-selector branch from 5f00737 to 67b419d Compare August 5, 2024 16:22
@@ -0,0 +1,7 @@
{
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.badgeMask.normal.chromium.png 2 Changed
Avatar Converged.basic - High Contrast.normal.chromium.png 0 Removed
SwatchPicker Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
SwatchPicker Converged.default - Dark Mode.default.chromium.png 0 Removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants