Skip to content

chore: fix invalid project configs and tweak .nxignore#33059

Merged
Hotell merged 4 commits intomicrosoft:masterfrom
Hotell:cleanup/various-nx-fixes
Oct 17, 2024
Merged

chore: fix invalid project configs and tweak .nxignore#33059
Hotell merged 4 commits intomicrosoft:masterfrom
Hotell:cleanup/various-nx-fixes

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 16, 2024

Previous Behavior

New Behavior

  • issues exposed by core nx plugins which run validations before invocation
  • bump jest test timeouts for expensive e2e test that cause regular CI failures on master
    • resolves all recent master failures image

Related Issue(s)

@Hotell Hotell changed the title Cleanup/various nx fixes chore: fix invalid project configs and tweak .nxignore Oct 16, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 16, 2024

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 16, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 16, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 653 643 5000
Button mount 307 308 5000
Field mount 1173 1195 5000
FluentProvider mount 722 747 5000
FluentProviderWithTheme mount 89 93 10
FluentProviderWithTheme virtual-rerender 32 38 10
FluentProviderWithTheme virtual-rerender-with-unmount 79 79 10
MakeStyles mount 868 858 50000
Persona mount 1826 1757 5000
SpinButton mount 1472 1425 5000
SwatchPicker mount 1698 1742 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 16, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 16, 2024

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ImageMinimalPerf.default 237 208 1.14:1
LoaderMinimalPerf.default 194 171 1.13:1
AttachmentMinimalPerf.default 86 79 1.09:1
VideoMinimalPerf.default 454 419 1.08:1
AccordionMinimalPerf.default 89 83 1.07:1
TreeWith60ListItems.default 94 88 1.07:1
AvatarMinimalPerf.default 113 107 1.06:1
ListMinimalPerf.default 318 301 1.06:1
PortalMinimalPerf.default 88 83 1.06:1
TableMinimalPerf.default 240 226 1.06:1
TextAreaMinimalPerf.default 296 278 1.06:1
ChatWithPopoverPerf.default 208 199 1.05:1
GridMinimalPerf.default 198 189 1.05:1
AnimationMinimalPerf.default 305 293 1.04:1
FormMinimalPerf.default 231 222 1.04:1
TextMinimalPerf.default 199 191 1.04:1
TooltipMinimalPerf.default 1330 1283 1.04:1
TreeMinimalPerf.default 498 480 1.04:1
DropdownManyItemsPerf.default 395 383 1.03:1
InputMinimalPerf.default 549 531 1.03:1
ItemLayoutMinimalPerf.default 696 679 1.03:1
LabelMinimalPerf.default 218 212 1.03:1
RadioGroupMinimalPerf.default 260 253 1.03:1
SegmentMinimalPerf.default 198 193 1.03:1
FlexMinimalPerf.default 157 154 1.02:1
RosterPerf.default 1614 1579 1.02:1
ReactionMinimalPerf.default 220 216 1.02:1
RefMinimalPerf.default 111 109 1.02:1
SplitButtonMinimalPerf.default 2234 2192 1.02:1
AlertMinimalPerf.default 150 149 1.01:1
ButtonMinimalPerf.default 87 86 1.01:1
ButtonOverridesMissPerf.default 659 655 1.01:1
ButtonSlotsPerf.default 309 306 1.01:1
ChatDuplicateMessagesPerf.default 149 147 1.01:1
HeaderSlotsPerf.default 449 445 1.01:1
ListWith60ListItems.default 360 357 1.01:1
PopupMinimalPerf.default 349 345 1.01:1
SkeletonMinimalPerf.default 197 195 1.01:1
TableManyItemsPerf.default 1089 1078 1.01:1
ToolbarMinimalPerf.default 538 535 1.01:1
CheckboxMinimalPerf.default 1123 1126 1:1
DatepickerMinimalPerf.default 3481 3481 1:1
DropdownMinimalPerf.default 1438 1442 1:1
EmbedMinimalPerf.default 1889 1885 1:1
HeaderMinimalPerf.default 210 211 1:1
ProviderMinimalPerf.default 197 197 1:1
IconMinimalPerf.default 409 408 1:1
DialogMinimalPerf.default 438 441 0.99:1
ProviderMergeThemesPerf.default 646 654 0.99:1
SliderMinimalPerf.default 744 753 0.99:1
AttachmentSlotsPerf.default 633 648 0.98:1
BoxMinimalPerf.default 193 197 0.98:1
CarouselMinimalPerf.default 257 261 0.98:1
MenuButtonMinimalPerf.default 932 954 0.98:1
CustomToolbarPrototype.default 1461 1489 0.98:1
LayoutMinimalPerf.default 196 203 0.97:1
ListCommonPerf.default 381 393 0.97:1
StatusMinimalPerf.default 381 393 0.97:1
CardMinimalPerf.default 292 308 0.95:1
ChatMinimalPerf.default 425 446 0.95:1
DividerMinimalPerf.default 200 210 0.95:1
ListNestedPerf.default 304 321 0.95:1
MenuMinimalPerf.default 486 511 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 16, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 630 634 5000
Breadcrumb mount 1713 1712 1000
Checkbox mount 1718 1759 5000
CheckboxBase mount 1467 1507 5000
ChoiceGroup mount 3049 3049 5000
ComboBox mount 682 699 1000
CommandBar mount 6647 6646 1000
ContextualMenu mount 11918 12122 1000
DefaultButton mount 818 814 5000
DetailsRow mount 2296 2303 5000
DetailsRowFast mount 2269 2235 5000
DetailsRowNoStyles mount 2047 2054 5000
Dialog mount 2706 2900 1000
DocumentCardTitle mount 240 240 1000
Dropdown mount 1983 2017 5000
FocusTrapZone mount 1183 1162 5000
FocusZone mount 1114 1115 5000
GroupedList mount 42380 42731 2
GroupedList virtual-rerender 20282 20448 2
GroupedList virtual-rerender-with-unmount 52316 52392 2
GroupedListV2 mount 230 234 2
GroupedListV2 virtual-rerender 215 211 2
GroupedListV2 virtual-rerender-with-unmount 226 237 2
IconButton mount 1161 1157 5000
Label mount 344 354 5000
Layer mount 2783 2802 5000
Link mount 400 402 5000
MenuButton mount 997 1016 5000
MessageBar mount 21816 21795 5000
Nav mount 2063 2051 1000
OverflowSet mount 791 766 5000
Panel mount 1820 1849 1000
Persona mount 764 738 1000
Pivot mount 899 922 1000
PrimaryButton mount 952 940 5000
Rating mount 4733 4776 5000
SearchBox mount 970 922 5000
Shimmer mount 1930 1908 5000
Slider mount 1346 1370 5000
SpinButton mount 3048 3029 5000
Spinner mount 399 392 5000
SplitButton mount 1954 1959 5000
Stack mount 422 430 5000
StackWithIntrinsicChildren mount 899 887 5000
StackWithTextChildren mount 2823 2815 5000
SwatchColorPicker mount 6430 6466 5000
TagPicker mount 1468 1533 5000
Text mount 399 380 5000
TextField mount 961 955 5000
ThemeProvider mount 880 862 5000
ThemeProvider virtual-rerender 587 589 5000
ThemeProvider virtual-rerender-with-unmount 1303 1331 5000
Toggle mount 611 601 5000
buttonNative mount 199 202 5000

@Hotell Hotell marked this pull request as ready for review October 16, 2024 16:51
@Hotell Hotell requested a review from a team as a code owner October 16, 2024 16:51
@Hotell Hotell merged commit 79b3357 into microsoft:master Oct 17, 2024
@Hotell Hotell deleted the cleanup/various-nx-fixes branch October 17, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants