Skip to content

RFC: React 18 upgrade#34018

Closed
marcosmoura wants to merge 15 commits intomicrosoft:masterfrom
marcosmoura:rfc/react-18-support
Closed

RFC: React 18 upgrade#34018
marcosmoura wants to merge 15 commits intomicrosoft:masterfrom
marcosmoura:rfc/react-18-support

Conversation

@marcosmoura
Copy link
Contributor

@marcosmoura marcosmoura commented Mar 17, 2025

This is a WIP PR to concentrate the work on writing the RFC for the upcoming React 18 support

@github-actions github-actions bot added the Type: RFC Request for Feedback label Mar 17, 2025
@github-actions
Copy link

Pull request demo site: URL

@github-actions
Copy link

github-actions bot commented Mar 17, 2025

📊 Bundle size report

✅ No changes found

@marcosmoura marcosmoura changed the title rfc: add first draft including some options with pros/cons RFC: add first draft including some options with pros/cons Mar 18, 2025
@marcosmoura marcosmoura changed the title RFC: add first draft including some options with pros/cons RFC: React 18 upgrade Mar 18, 2025

#### Cons

- 👎 The biggest challenge is how we currently communicate our library to partners. We have the explicit (and sometimes implicit) nomenclature "Fluent UI v9" everywhere, including chats, meetings, documents, e-mails, pipelines, folder structures and more. Even the root folder where this RFC document is located receive the react-v9 prefix.\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is not only with communication - applications often integrate code from various code repositories and this makes the promise of no breaking changes important - Package A comes from repo 1 and uses a new version of the code. Package B comes from repo 2 and uses an old version of the code. eventually both packages come to one app and need to work together, in some cases without the possibility of having multiple versions of dependencies bundled. Coordinating versions across different repos is a difficult challenge.


- 👎 It would require some strategy to deprecate this compat package in the future
- 👎 Could bring some confusion to partners on why this is necessary
- 👎 Same other cons as option 1-a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any cons explicitly listed in option 1-a


#### Pros

- 👍 Avoid the fear of a new major release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I understand this would have same implications for consumers as having a new major version. the challenge is not with communication, the challenge is with shipping two incompatible APIs in one app together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: RFC Request for Feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants