Skip to content

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented May 2, 2025

Previous Behavior

New Behavior

problematic tests

if act is used , they fail with react 17 - blocking current main pipeline

  • packages/react/src/components/TextField/TextField.test.tsx
  • packages/react/src/components/ExtendedPicker/BaseExtendedPicker.test.tsx:344:52

failing snapshots

These snapshots differ because react-test-renderer breaking changes between r17 and r18 output.

For that reason we are running jest in updateSnapshots mode on CI to not get false positives on test pass rate

FAIL react-18-tests-v8-integration ../../packages/react/src/components/pickers/BasePicker.test.tsx
FAIL react-18-tests-v8-integration ../../packages/react/src/components/Pivot/Pivot.test.tsx
FAIL react-18-tests-v8-integration ../../packages/react/src/components/DatePicker/DatePicker.test.tsx
FAIL react-18-tests-v8-integration ../../packages/react/src/components/Pivot/Pivot.deprecated.test.tsx
FAIL react-18-tests-v8-integration ../../packages/react/src/components/Nav/Nav.test.tsx
FAIL react-18-tests-v8-integration ../../packages/react/src/components/Rating/Rating.test.tsx
FAIL react-18-tests-v8-integration ../../packages/react/src/components/pickers/TagPicker/TagPicker.test.tsx
FAIL react-18-tests-v8-integration ../../packages/react/src/components/pickers/PeoplePicker/PeoplePicker.test.tsx
FAIL react-18-tests-v8-integration ../../packages/react/src/components/DetailsList/DetailsRow.test.tsx
FAIL react-18-tests-v8-integration ../../packages/react/src/components/DocumentCard/DocumentCard.test.tsx

Related Issue(s)

  • Fixes #

@Hotell Hotell changed the title React 18/integration v8/5 test: resolve v8 act() issues with react 18 May 2, 2025
@Hotell Hotell added Area: Testing Fluent UI react (v8) Issues about @fluentui/react (v8) React 18 labels May 2, 2025
@github-actions
Copy link

github-actions bot commented May 2, 2025

📊 Bundle size report

✅ No changes found

@github-actions
Copy link

github-actions bot commented May 2, 2025

Pull request demo site: URL

@Hotell Hotell force-pushed the react-18/integration-v8/5 branch 3 times, most recently from 11bfd00 to de7db8e Compare May 2, 2025 15:10
@Hotell Hotell force-pushed the react-18/integration-v8/5 branch from de7db8e to 180ef1c Compare May 6, 2025 08:17
@Hotell
Copy link
Contributor Author

Hotell commented May 6, 2025

replaced by #34376

@Hotell Hotell closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Testing Fluent UI react (v8) Issues about @fluentui/react (v8) React 18

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant