(fix): Replace unsafe expression evaluation with safe recursive-descent parser in VegaDeclarativeChart#35852
Merged
AtishayMsft merged 5 commits intomicrosoft:masterfrom Mar 10, 2026
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Contributor
|
Should I close my proposed fix ? #35851 as I mentioned on the issue, having full tokenizer in runtime might be a bit of a huge tax to pay. the |
Contributor
Author
The tokenization is needed for only the transform set which is pretty small. We should be good with this. |
srmukher
approved these changes
Mar 10, 2026
tudorpopams
pushed a commit
to tudorpopams/fluentui
that referenced
this pull request
Apr 14, 2026
…nt parser in VegaDeclarativeChart (microsoft#35852) Co-authored-by: Atishay Jain <atisjai@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)