fix(react-badge): fix PresenceBadge aria-label regression#35927
Merged
dmytrokirpa merged 3 commits intomicrosoft:masterfrom Mar 30, 2026
Merged
Conversation
bsunderhus
approved these changes
Mar 30, 2026
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ValentinaKozlova
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
A regression were introduced in the https://github.com/microsoft/fluentui/pull/35811/changes#diff-9c774d77d8e2010b729c9bb7129760b51e0f2aa25d2441f101e915bc28e78655R69 where incorrect
aria-label="available"was always applied to PresenceBadge without taking into account thestatuspropThe root cause of the issue is that the
statusis not passed to base hook, but it should be.New Behavior
Pass the
statusto base hook, so aria-label could be resolved properlyAdded tests to ensure the behavior is correct and won't regress in future.
Related Issue(s)