Skip to content

fix(react-tabster): mitigate hidden sideEffects by explicitly using type imports and decoupling useDangerousNeverHidden from tabster import path#35933

Merged
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:v9/tabster-side-effect-fix
Apr 2, 2026
Merged

fix(react-tabster): mitigate hidden sideEffects by explicitly using type imports and decoupling useDangerousNeverHidden from tabster import path#35933
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:v9/tabster-side-effect-fix

Conversation

@Hotell
Copy link
Copy Markdown
Contributor

@Hotell Hotell commented Mar 31, 2026

Previous Behavior

New Behavior

  • fixes tabster tree-shaking if useDangerousNeverHidden_unstable is used only within dep graph, by explicitly decoupling the hook to separate module + importing tabster types via explicit types which is removed on transpilation

Related Issue(s)

…ype imports and decoupling useDangerousNeverHidden from tabster import path
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-aria
ARIA - useARIAButtonProps
0 B
0 B
1.354 kB
648 B
🆕 New entry
react-aria
ARIA - AriaLiveAnnouncer
0 B
0 B
3.293 kB
1.507 kB
🆕 New entry
react-dialog
Dialog (including children components)
102.12 kB
30.394 kB
102.117 kB
30.367 kB
-3 B
-27 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
103.484 kB
31.344 kB
react-avatar
Avatar
48.393 kB
15.335 kB
react-avatar
AvatarGroup
17.45 kB
6.995 kB
react-avatar
AvatarGroupItem
61.634 kB
19.325 kB
react-breadcrumb
@fluentui/react-breadcrumb - package
115.355 kB
31.542 kB
react-button
Button
33.962 kB
9.022 kB
react-button
CompoundButton
40.843 kB
10.379 kB
react-button
MenuButton
38.866 kB
10.414 kB
react-button
SplitButton
47.663 kB
12.057 kB
react-button
ToggleButton
53.634 kB
11.155 kB
react-calendar-compat
Calendar Compat
149.292 kB
39.866 kB
react-card
Card - All
105.222 kB
29.475 kB
react-card
Card
97.84 kB
27.583 kB
react-card
CardFooter
12.774 kB
5.117 kB
react-card
CardHeader
15.303 kB
5.976 kB
react-card
CardPreview
12.854 kB
5.252 kB
react-charts
AreaChart
412.369 kB
126.436 kB
react-charts
DeclarativeChart
763.093 kB
220.471 kB
react-charts
DonutChart
322.798 kB
96.987 kB
react-charts
FunnelChart
314.351 kB
94.048 kB
react-charts
GanttChart
395.488 kB
119.947 kB
react-charts
GaugeChart
322.229 kB
96.435 kB
react-charts
GroupedVerticalBarChart
403.358 kB
122.516 kB
react-charts
HeatMapChart
397.559 kB
121.802 kB
react-charts
HorizontalBarChart
302.525 kB
89.127 kB
react-charts
HorizontalBarChartWithAxis
63 B
83 B
react-charts
Legends
242.471 kB
71.602 kB
react-charts
LineChart
423.71 kB
128.491 kB
react-charts
PolarChart
351.416 kB
107.38 kB
react-charts
SankeyChart
220.381 kB
67.866 kB
react-charts
ScatterChart
403.085 kB
122.621 kB
react-charts
Sparkline
91.393 kB
28.708 kB
react-charts
VerticalBarChart
439.829 kB
128.225 kB
react-charts
VerticalStackedBarChart
409.354 kB
124.017 kB
react-checkbox
Checkbox
33.408 kB
11.361 kB
react-color-picker
ColorArea
47.538 kB
16.698 kB
react-color-picker
ColorPicker
16.169 kB
6.523 kB
react-color-picker
ColorSlider
39.712 kB
14.744 kB
react-combobox
Combobox (including child components)
105.208 kB
34.168 kB
react-combobox
Dropdown (including child components)
105.832 kB
34.1 kB
react-components
react-components: Button, FluentProvider & webLightTheme
70.397 kB
19.96 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
236.663 kB
68.729 kB
react-components
react-components: FluentProvider & webLightTheme
43.612 kB
14.022 kB
react-components
react-components: entire library
1.297 MB
324.105 kB
react-datepicker-compat
DatePicker Compat
225.158 kB
63.633 kB
react-field
Field
22.083 kB
8.337 kB
react-input
Input
26.28 kB
8.702 kB
react-link
Link
16.173 kB
6.457 kB
react-list
List
87.11 kB
25.762 kB
react-list
ListItem
110.725 kB
32.622 kB
react-menu
Menu (including children components)
170.313 kB
51.895 kB
react-menu
Menu (including selectable components)
173.491 kB
52.475 kB
react-message-bar
MessageBar (all components)
23.294 kB
8.63 kB
react-overflow
hooks only
12.117 kB
4.627 kB
react-persona
Persona
55.348 kB
17.279 kB
react-popover
Popover
133.719 kB
41.451 kB
react-portal
Portal
15.55 kB
5.398 kB
react-portal-compat
PortalCompatProvider
8.386 kB
2.624 kB
react-positioning
usePositioning
28.889 kB
10.158 kB
react-positioning
useSafeZoneArea
12.445 kB
5 kB
react-progress
ProgressBar
20.097 kB
7.834 kB
react-provider
FluentProvider
23 kB
8.194 kB
react-radio
Radio
31.036 kB
9.638 kB
react-radio
RadioGroup
14.035 kB
5.7 kB
react-select
Select
26.085 kB
9.437 kB
react-slider
Slider
36.356 kB
12.08 kB
react-spinbutton
SpinButton
33.804 kB
11.125 kB
react-swatch-picker
@fluentui/react-swatch-picker - package
104.305 kB
29.944 kB
react-switch
Switch
36.105 kB
11.011 kB
react-table
DataGrid
159.481 kB
44.953 kB
react-table
Table (Primitives only)
40.997 kB
13.172 kB
react-table
Table as DataGrid
130.702 kB
35.962 kB
react-table
Table (Selection only)
69.089 kB
19.325 kB
react-table
Table (Sort only)
67.732 kB
18.942 kB
react-tag-picker
@fluentui/react-tag-picker - package
186.596 kB
55.849 kB
react-tags
InteractionTag
13.666 kB
5.459 kB
react-tags
Tag
29.521 kB
9.389 kB
react-tags
TagGroup
82.211 kB
24.143 kB
react-teaching-popover
TeachingPopover
112.414 kB
34.219 kB
react-textarea
Textarea
24.668 kB
8.969 kB
react-timepicker-compat
TimePicker
108.174 kB
35.695 kB
react-toast
Toast (including Toaster)
102.56 kB
30.608 kB
react-tooltip
Tooltip
57.1 kB
19.696 kB
react-tree
FlatTree
147.803 kB
42.147 kB
react-tree
PersonaFlatTree
149.631 kB
42.53 kB
react-tree
PersonaTree
145.691 kB
41.358 kB
react-tree
Tree
143.869 kB
40.986 kB
🤖 This report was generated against 0e111eb97a7df1642e15cb0618670ba56f0abe9f

@github-actions
Copy link
Copy Markdown

Pull request demo site: URL

@Hotell Hotell marked this pull request as ready for review March 31, 2026 12:24
@Hotell Hotell requested a review from a team as a code owner March 31, 2026 12:24
@Hotell Hotell enabled auto-merge (squash) April 1, 2026 08:45
@Hotell Hotell merged commit fc37669 into microsoft:master Apr 2, 2026
12 checks passed
@Hotell Hotell deleted the v9/tabster-side-effect-fix branch April 2, 2026 07:34
tudorpopams pushed a commit to tudorpopams/fluentui that referenced this pull request Apr 14, 2026
…ype imports and decoupling useDangerousNeverHidden from tabster import path (microsoft#35933)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Improve tree-shaking for LiveAriaAnnouncer

2 participants