feat(react-headless-components-preview): add Dialog component#35996
Draft
dmytrokirpa wants to merge 8 commits intomicrosoft:masterfrom
Draft
feat(react-headless-components-preview): add Dialog component#35996dmytrokirpa wants to merge 8 commits intomicrosoft:masterfrom
dmytrokirpa wants to merge 8 commits intomicrosoft:masterfrom
Conversation
📊 Bundle size report
🤖 This report was generated against 3d2d9bf0e07e05f2320e5400efe6c01759426534 |
|
Pull request demo site: URL |
…vior Co-authored-by: Dmytro Kirpa <dmytrokirpa@users.noreply.github.com>
…cy-fe45 Update headless Dialog e2e tests for native <dialog> behavior
…t, and enhance scroll behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
n/a
New Behavior
This PR introduces the initial headless Dialog component API to the Fluent UI React Headless Components Preview package. It adds all core Dialog primitives (such as
Dialog,DialogSurface,DialogHeader,DialogBody,DialogActions,DialogTitle, andDialogTrigger), their associated state hooks, context types, and render functions. The update also includes a comprehensive spec document for Dialog, a Cypress configuration, and a Jest test shim for the<dialog>element.Headless Dialog Component API
Dialog,DialogSurface,DialogHeader,DialogBody,DialogActions,DialogTitle,DialogTrigger) with their respective prop types, state types, context types, and slot definitions to the public API (etc/react-headless-components-preview.api.md).useDialog_unstable,useDialogSurface_unstable, etc.) and render functions (e.g.,renderDialog_unstable,renderDialogSurface_unstable, etc.) for each Dialog primitive.DialogOpenChangeData,DialogOpenChangeEventHandler, and modal type definitions.Documentation
docs/dialog-spec.md) describing composition, props, states, events, accessibility, controlled/uncontrolled usage, RTL support, and more.Testing & Tooling
cypress.config.ts).<dialog>element to support Dialog component tests in JSDOM environments (config/tests.js).Related Issue(s)