test(react-toast): add hook-level tests for toast components#36044
Open
dmytrokirpa wants to merge 16 commits into
Open
test(react-toast): add hook-level tests for toast components#36044dmytrokirpa wants to merge 16 commits into
dmytrokirpa wants to merge 16 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…oastBody, useToastTitle Tests lock down the exact behaviors that PR microsoft#35914 refactors — backgroundAppearance mapping, context reads (intent, bodyId, titleId), and the media slot default-icon injection by intent — so any regression introduced by the base-hooks refactor will be caught immediately. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…sertions The `components` property is deprecated but these tests intentionally verify its shape as a regression guard while the API contract still exists. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds hook-level regression tests for useToast_unstable, useToastBody_unstable, and useToastTitle_unstable to lock down current behavior before the base-hook refactor in #35914 lands.
Changes:
- New unit tests for
useToast_unstablecovering components/slots,backgroundAppearancederivation fromappearanceprop,intentfrom context, and prop spreading. - New unit tests for
useToastBody_unstablecovering slots,bodyIdwiring, subtitle behavior, andbackgroundAppearancefrom context. - New unit tests for
useToastTitle_unstablecovering slots,titleIdwiring, intent handling, default media icon injection per intent, and user override behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react-components/react-toast/library/src/components/Toast/useToast.test.ts | Adds 8 hook tests for useToast_unstable. |
| packages/react-components/react-toast/library/src/components/ToastBody/useToastBody.test.ts | Adds 10 hook tests for useToastBody_unstable. |
| packages/react-components/react-toast/library/src/components/ToastTitle/useToastTitle.test.tsx | Adds 19 hook tests for useToastTitle_unstable, including default icon injection per intent. |
dmytrokirpa
changed the title
This was referenced May 14, 2026
Inline RootSlot as Slot<'div'> in DispatchToastOptions/UpdateToastOptions and export ToastOptions and UpdateToastEventDetail so the api-extractor report no longer references undeclared private types. Also suppress react-compiler on useToastTitle_unstable to allow inline mutation of the media slot's default icon. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…-regression-tests
Lock in the headless contract: useToastBase_unstable returns no backgroundAppearance, useToastBodyBase_unstable does not read it from context, and useToastTitleBase_unstable does not inject the intent's default media icon. These regressions would break headless consumers without these assertions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds hook-level tests for toast components.
Stacking Note
This PR is part of a stacked series and should be merged in order.
Merge order: