Skip to content

fix(Option): when disabled, hover styles should not show#36077

Merged
smhigley merged 2 commits into
microsoft:masterfrom
smhigley:disabled-option-hover
Apr 30, 2026
Merged

fix(Option): when disabled, hover styles should not show#36077
smhigley merged 2 commits into
microsoft:masterfrom
smhigley:disabled-option-hover

Conversation

@smhigley
Copy link
Copy Markdown
Contributor

Previous Behavior

oops hover styles in HCM

New Behavior

split the hover/active styles into an interactive block, similar to what we do in other components, and only add that block when not disabled.

Related Issue(s)

@smhigley smhigley requested review from a team and dmytrokirpa as code owners April 30, 2026 05:29
@github-actions
Copy link
Copy Markdown

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-combobox
Combobox (including child components)
106.709 kB
34.573 kB
105.459 kB
34.352 kB
-1.25 kB
-221 B
react-combobox
Dropdown (including child components)
106.479 kB
34.32 kB
105.229 kB
34.094 kB
-1.25 kB
-226 B
react-components
react-components: entire library
1.303 MB
325.567 kB
1.301 MB
325.381 kB
-1.25 kB
-186 B
react-tag-picker
@fluentui/react-tag-picker - package
187.014 kB
55.911 kB
185.767 kB
55.697 kB
-1.247 kB
-214 B
react-timepicker-compat
TimePicker
109.674 kB
36.193 kB
108.424 kB
35.958 kB
-1.25 kB
-235 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
70.415 kB
19.963 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
237.729 kB
68.993 kB
react-components
react-components: FluentProvider & webLightTheme
43.63 kB
14.026 kB
react-portal-compat
PortalCompatProvider
8.386 kB
2.624 kB
🤖 This report was generated against 5a5a37c79ea6183e8b50972224ef03c82596c050

@github-actions
Copy link
Copy Markdown

Pull request demo site: URL

@smhigley smhigley merged commit 080f397 into microsoft:master Apr 30, 2026
12 checks passed
@smhigley smhigley deleted the disabled-option-hover branch April 30, 2026 21:45
mainframev pushed a commit to mainframev/fluentui that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants