Updated bar role from image to button based on the props to fix voice control issue in accessibility mode#36096
Open
v-baambati wants to merge 21 commits into
Open
Updated bar role from image to button based on the props to fix voice control issue in accessibility mode#36096v-baambati wants to merge 21 commits into
v-baambati wants to merge 21 commits into
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
krkshitij
reviewed
May 5, 2026
…ay_2026BugFixes
…ay_2026BugFixes
…ay_2026BugFixes
…ay_2026BugFixes
krkshitij
reviewed
May 20, 2026
krkshitij
reviewed
May 20, 2026
AtishayMsft
reviewed
May 25, 2026
…ay_2026BugFixes
…ay_2026BugFixes
AtishayMsft
reviewed
Jun 4, 2026
| <g | ||
| role="listbox" | ||
| id={keyVal} | ||
| aria-label={chartGroupAriaLabel} |
Contributor
There was a problem hiding this comment.
The outer svg already has aria label. Is aria label necessary here
Contributor
Author
There was a problem hiding this comment.
Yes @AtishayMsft otherwise it is throwing error in fast pass tool. FFB
Fix ONE of the following:
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Contributor
There was a problem hiding this comment.
did you try setting the title attribute
Contributor
Author
There was a problem hiding this comment.
Yes @AtishayMsft SVG element does not have title prop so it is forcing me to add aria label
Contributor
There was a problem hiding this comment.
What about the aria-labelledby attribute of the outer containing svg element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AccessibilityIssuesFix.mp4
BUG: https://office.visualstudio.com/OC/_workitems/edit/11472365