Add correctly spelled chart axis label props#36242
Closed
KirtiRamchandani wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this because I missed the already-open PR #36216 for the same issue. Keeping both open would create duplicate review work for maintainers. Thanks, and apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
ICartesianChartPropsexposed several public axis label props with the misspellingLables, such asshowXAxisLablesTooltip,wrapXAxisLables,rotateXAxisLables,showYAxisLablesTooltip, andshowYAxisLables.New Behavior
Adds correctly spelled aliases for those public props:
showXAxisLabelsTooltipwrapXAxisLabelsrotateXAxisLabelsshowYAxisLabelsTooltipshowYAxisLabelsThe existing misspelled props remain supported and are marked deprecated, so this is backwards-compatible. Runtime handling now prefers the corrected prop when both spellings are provided, and falls back to the legacy prop otherwise.
Related Issue(s)
Fixes #34872
Validation
corepack yarn nx run react-charting:buildcorepack yarn nx run react-charting:lintcorepack yarn jest --runInBand src\components\VerticalBarChart\VerticalBarChart.test.tsx src\components\HorizontalBarChartWithAxis\HorizontalBarChartWithAxis.test.tsx src\components\DeclarativeChart\PlotlySchemaAdapterUT.test.tsxcorepack yarn beachball check --branch origin/master