feat(eslint-rules): add base-hook-no-forbidden-runtime rule by Hotell · Pull Request #36253 · microsoft/fluentui

Hotell · 2026-05-26T14:04:06Z

Summary

Introduces a new workspace ESLint rule @nx/workspace-base-hook-no-forbidden-runtime that prevents useFooBase / useFooBase_unstable hooks from pulling in heavy runtime dependencies. It walks the imports of the base-hook module and flags transitive dependencies on packages outside an allowlist.

The rule is fully inert in this PR — it is registered with @nx/workspace but not enabled in any project config. Wiring happens in a follow-up PR.

Plan reference

Part of the split of #36251

Fixtures

Self-contained fixture workspace under tools/eslint-rules/rules/__fixtures__/base-hook-no-forbidden-runtime/ includes a local tsconfig.json plus stub packages: light-helper, heavy-runtime, watched-pkg (with light.ts / heavy.ts paths), and cyclic-pkg (a → b → index → a cycle) to verify cycle handling.

Verification

nx run eslint-rules:test --skip-nx-cache

→ 4 suites / 56 tests pass.

ESLint CLI perf (TIMING=200)

Measured on a combined branch (PR1 + PR2 + PR3 wiring) so the rule actually runs.

Project	`@nx/workspace-base-hook-no-forbidden-runtime`	% of total
`react-button` (no `*Base` hook)	0.56 ms	0.0%
`react-combobox` (1 `*Base` hook)	0.90 ms	0.0%
`react-tags` (1 `*Base` hook)	0.83 ms	0.0%

Negligible — the rule short-circuits on non-base-hook files and the import graph walk is bounded + cycle-safe.

Out of scope

Wiring into @fluentui/eslint-plugin (separate PR).
Beachball change file (declined — tooling-only change).

github-actions · 2026-05-26T14:08:05Z

📊 Bundle size report

✅ No changes found

github-actions · 2026-05-26T14:10:48Z

Pull request demo site: URL

Copilot

Pull request overview

Adds a new workspace ESLint rule (@nx/workspace-base-hook-no-forbidden-runtime) intended to prevent v9 use*Base_unstable hooks from (directly or transitively) depending on forbidden runtime packages, with a dedicated typed + untyped test/fixture setup.

Changes:

Introduces the base-hook-no-forbidden-runtime rule with transitive import-graph reach analysis (value vs type reach) and a one-shot warning when type info is missing.
Adds RuleTester coverage plus a self-contained fixture workspace (stub packages + tsconfig) to validate transitive reach and cycle handling.
Updates eslint-rules workspace config to exclude fixture files from lint compilation, and registers the rule in the workspace rules index.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tools/eslint-rules/tsconfig.lint.json	Excludes `__fixtures__` from lint tsconfig to avoid fixture compilation/lint noise.
tools/eslint-rules/rules/base-hook-no-forbidden-runtime.ts	Implements the new rule, including import tracking, scope analysis, and transitive reach computation.
tools/eslint-rules/rules/base-hook-no-forbidden-runtime.spec.ts	Adds untyped + typed RuleTester suites covering direct forbidden imports, transitive reach, and cycles.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/tsconfig.json	Fixture TS project config with path mappings to stub packages for typed tests.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/stubs/watched-pkg/light.ts	Stub “light” module that should not reach the forbidden runtime.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/stubs/watched-pkg/index.ts	Stub package entrypoint with mixed value/type re-exports to exercise reach semantics.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/stubs/watched-pkg/heavy.ts	Stub “heavy” module that imports the forbidden runtime.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/stubs/light-helper/index.ts	Stub helper package used by the “light” module.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/stubs/heavy-runtime/index.ts	Stub forbidden runtime package used to validate direct + transitive blocking.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/stubs/cyclic-pkg/index.ts	Stub cyclic package entrypoint to exercise cycle safety.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/stubs/cyclic-pkg/b.ts	Part of a cyclic import graph in the fixture.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/stubs/cyclic-pkg/a.ts	Part of a cyclic import graph in the fixture.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/src/test.ts	Placeholder file so the typed Program contains the filename used in RuleTester cases.
tools/eslint-rules/rules/fixtures/base-hook-no-forbidden-runtime/src/dummy.ts	Additional placeholder/anchor file in the fixture project.
tools/eslint-rules/index.ts	Registers the new rule in the exported workspace rules map.

mainframev · 2026-05-28T21:33:29Z

+type BaseHookFunction = TSESTree.FunctionDeclaration | TSESTree.FunctionExpression | TSESTree.ArrowFunctionExpression;
+
+const DEFAULT_WATCHED_PACKAGES: ReadonlyArray<string> = ['@fluentui/react-tabster'];
+const DEFAULT_FORBIDDEN_RUNTIMES: ReadonlyArray<string> = ['tabster'];


should we add @floating-ui/dom, @floating-ui/react to DEFAULT_FORBIDDEN_RUNTIMES and @fluentui/react-positioning to DEFAULT_WATCHED_PACKAGES? Or you plan to add on config level via options? (two base hooks still have react-positioning: useTooltipBase_unstable & useMenuBase_unstable, but they are not used in headless, so we should revert it)

floating - not atm, we might need it as progressive enhancement pattern for headless.

so we should revert it

what should we revert ?

the base hooks that are not used in headless (with react-positioning, in Menu and Tooltip)

IMO we can keep them to follow our "base hook" established pattern, the thing that they use internally fui/r-positioning/floating ui is ok for now. if we will come to the point that we wanna use them in headless we will refactor. wdyt ?

Registers @nx/workspace-base-hook-no-forbidden-runtime. Rule is not yet enabled in any project config and is fully inert until wired up in a follow-up PR.

Cache in-progress reach results to preserve transitive closure across import cycles, normalize diagnostic paths cross-platform, and add cyclic regression fixtures/tests.

…er review feedback Address reviewer feedback from PR microsoft#36253: - Add SymbolReach type alias for return value clarity (mainframev suggestion) - Extract getImportSymbolNameNode helper to reduce nested import logic (mainframev suggestion) - Remove redundant casts to ImportSpecifierNode in tracked imports (mainframev suggestion) - Remove legacy TypeScript fallback in resolveModule; require TS >=5.3 behavior only (mainframev suggestion) All changes maintain existing behavior and pass the full eslint-rules test suite (85 tests). getFunctionInit remains duplicated to avoid creating a new shared module per user preference.

github-actions Bot added the NX: workspace eslint-rules label May 26, 2026

Hotell requested a review from Copilot May 26, 2026 16:49

Copilot started reviewing on behalf of Hotell May 26, 2026 16:50 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

Comment thread tools/eslint-rules/rules/base-hook-no-forbidden-runtime.ts Outdated

Comment thread tools/eslint-rules/rules/base-hook-no-forbidden-runtime.ts Outdated

Hotell marked this pull request as ready for review May 26, 2026 17:44

Hotell requested a review from a team as a code owner May 26, 2026 17:44

Hotell force-pushed the tools/ws-lint/rule-base-hook-no-forbidden-runtime branch from 47ccc8e to 18d8549 Compare May 27, 2026 18:22

tudorpopams requested a review from mainframev May 28, 2026 12:03

mainframev requested changes May 29, 2026

View reviewed changes

Hotell added 3 commits May 29, 2026 14:03

feat(eslint-rules): add base-hook-no-forbidden-runtime rule

5e89f26

Registers @nx/workspace-base-hook-no-forbidden-runtime. Rule is not yet enabled in any project config and is fully inert until wired up in a follow-up PR.

fix(eslint-rules): make base-hook runtime reach cycle-safe

89d2965

Cache in-progress reach results to preserve transitive closure across import cycles, normalize diagnostic paths cross-platform, and add cyclic regression fixtures/tests.

Hotell force-pushed the tools/ws-lint/rule-base-hook-no-forbidden-runtime branch from 18d8549 to a1c78dd Compare May 29, 2026 12:19

Hotell requested a review from mainframev May 29, 2026 12:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-rules): add base-hook-no-forbidden-runtime rule#36253

feat(eslint-rules): add base-hook-no-forbidden-runtime rule#36253
Hotell wants to merge 3 commits into
microsoft:masterfrom
Hotell:tools/ws-lint/rule-base-hook-no-forbidden-runtime

Hotell commented May 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

mainframev May 28, 2026 •

edited

Loading

Uh oh!

Hotell May 29, 2026

Uh oh!

mainframev May 29, 2026

Uh oh!

Hotell Jun 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Hotell commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Plan reference

Fixtures

Verification

ESLint CLI perf (TIMING=200)

Out of scope

Uh oh!

github-actions Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

mainframev May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hotell May 29, 2026

Choose a reason for hiding this comment

Uh oh!

mainframev May 29, 2026

Choose a reason for hiding this comment

Uh oh!

Hotell Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hotell commented May 26, 2026 •

edited

Loading

github-actions Bot commented May 26, 2026 •

edited

Loading

mainframev May 28, 2026 •

edited

Loading

Hotell Jun 1, 2026 •

edited

Loading